Add modernize-redundant-void-arg check to clang-tidy (phate#694)

EECS-NTNU · Dec 21, 2024 · 4821290 · 4821290
1 parent 0ac4805
commit 4821290
Show file tree

Hide file tree

Showing 21 changed files with 64 additions and 62 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -1,8 +1,10 @@
 ---
 Checks: '-*,
   modernize-deprecated-headers,
+  modernize-redundant-void-arg,
   '
 
 WarningsAsErrors: '
   modernize-deprecated-headers,
+  modernize-redundant-void-arg,
   '
diff --git a/jlm/rvsdg/binary.cpp b/jlm/rvsdg/binary.cpp
@@ -522,7 +522,7 @@ flattened_binary_operation_get_default_normal_form_(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::binary_op),

diff --git a/jlm/rvsdg/bitstring/concat.cpp b/jlm/rvsdg/bitstring/concat.cpp
@@ -237,7 +237,7 @@ get_default_normal_form(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::bitconcat_op),

diff --git a/jlm/rvsdg/gamma.cpp b/jlm/rvsdg/gamma.cpp
@@ -471,7 +471,7 @@ gamma_node_get_default_normal_form_(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::GammaOperation),

diff --git a/jlm/rvsdg/node.cpp b/jlm/rvsdg/node.cpp
@@ -147,7 +147,7 @@ node_get_default_normal_form_(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::Operation),

diff --git a/jlm/rvsdg/nullary.cpp b/jlm/rvsdg/nullary.cpp
@@ -44,7 +44,7 @@ nullary_operation_get_default_normal_form_(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::nullary_op),

diff --git a/jlm/rvsdg/simple-normal-form.cpp b/jlm/rvsdg/simple-normal-form.cpp
@@ -119,7 +119,7 @@ get_default_normal_form(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::SimpleOperation),

diff --git a/jlm/rvsdg/statemux.cpp b/jlm/rvsdg/statemux.cpp
@@ -210,7 +210,7 @@ create_mux_normal_form(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::mux_op),

diff --git a/jlm/rvsdg/structural-normal-form.cpp b/jlm/rvsdg/structural-normal-form.cpp
@@ -31,7 +31,7 @@ get_default_normal_form(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::StructuralOperation),

diff --git a/jlm/rvsdg/unary.cpp b/jlm/rvsdg/unary.cpp
@@ -110,7 +110,7 @@ unary_operation_get_default_normal_form_(
 }
 
 static void __attribute__((constructor))
-register_node_normal_form(void)
+register_node_normal_form()
 {
   jlm::rvsdg::node_normal_form::register_factory(
       typeid(jlm::rvsdg::unary_op),

diff --git a/jlm/util/intrusive-hash.hpp b/jlm/util/intrusive-hash.hpp
@@ -173,7 +173,7 @@ class intrusive_hash
     {}
 
     inline const iterator &
-    operator++(void) noexcept
+    operator++() noexcept
     {
       ElementType * next = map_->accessor_.get_next(element_);
       if (next == nullptr)
@@ -262,7 +262,7 @@ class intrusive_hash
     {}
 
     inline const const_iterator &
-    operator++(void) noexcept
+    operator++() noexcept
     {
       ElementType * next = map_->accessor_.get_next(element_);
       if (next == nullptr)

diff --git a/jlm/util/intrusive-list.hpp b/jlm/util/intrusive-list.hpp
@@ -116,7 +116,7 @@ class intrusive_list
     {}
 
     inline const iterator &
-    operator++(void) noexcept
+    operator++() noexcept
     {
       element_ = list_->accessor_.get_next(element_);
       return *this;
@@ -131,7 +131,7 @@ class intrusive_list
     }
 
     inline const iterator &
-    operator--(void) noexcept
+    operator--() noexcept
     {
       if (element_)
       {
@@ -216,7 +216,7 @@ class intrusive_list
     {}
 
     inline const const_iterator &
-    operator++(void) noexcept
+    operator++() noexcept
     {
       element_ = list_->accessor_.get_next(element_);
       return *this;
@@ -231,7 +231,7 @@ class intrusive_list
     }
 
     inline const const_iterator &
-    operator--(void) noexcept
+    operator--() noexcept
     {
       if (element_)
       {