Fix test issues #20
Merged
Fix test issues #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruithofa
requested review from
aescolar,
heri-developer,
mtpr-ot and
joerchan
|
@auroraslb Could you add some more information in the commit changes about why the change and why it is needed? |
auroraslb
force-pushed
the
edtt_with_nrfxlib
branch
from
455805b
to
96a7306
Compare
joerchan
requested changes
Sep 3, 2020
src/components/basic_commands.py
Outdated
| if ( status == 0 ): | ||
| packet = transport.recv(idx, 6, to); | ||
| if ( 6 != len(packet) ): | ||
| raise Exception("LE Read Peer Resolvable Address command failed: Response too short (Expected %i bytes got %i bytes)" % (11, len(packet))); |
There was a problem hiding this comment.
Suggested change
| raise Exception("LE Read Peer Resolvable Address command failed: Response too short (Expected %i bytes got %i bytes)" % (11, len(packet))); | |
| raise Exception("LE Read Peer Resolvable Address command failed: Response too short (Expected %i bytes got %i bytes)" % (6, len(packet))); |
src/components/basic_commands.py
Outdated
| if ( status == 0 ): | ||
| packet = transport.recv(idx, 6, to); | ||
| if ( 6 != len(packet) ): | ||
| raise Exception("LE Read Local Resolvable Address command failed: Response too short (Expected %i bytes got %i bytes)" % (11, len(packet))); |
There was a problem hiding this comment.
Suggested change
| raise Exception("LE Read Local Resolvable Address command failed: Response too short (Expected %i bytes got %i bytes)" % (11, len(packet))); | |
| raise Exception("LE Read Local Resolvable Address command failed: Response too short (Expected %i bytes got %i bytes)" % (6, len(packet))); |
auroraslb
force-pushed
the
edtt_with_nrfxlib
branch
from
96a7306
to
7bc8baa
Compare
kruithofa
requested changes
Sep 10, 2020
joerchan
approved these changes
Sep 11, 2020
After the change, the test is matching the LL test specification. Signed-off-by: Sletnes Bjørlo, Aurora <[email protected]>
In some cases these were interchanged between upper and lower tester Signed-off-by: Sletnes Bjørlo, Aurora <[email protected]>
…e to be properly updated. The variable would previously not be updated in all cases where there was a change in values. After the change, these tests are matching the LL test specification. Signed-off-by: Sletnes Bjørlo, Aurora <[email protected]>
Fix inconstancy in address use. The lower is using a public address. Signed-off-by: Sletnes Bjørlo, Aurora <[email protected]>
auroraslb
force-pushed
the
edtt_with_nrfxlib
branch
from
7bc8baa
to
3fa0b8f
Compare
heri-developer
approved these changes
Sep 17, 2020
kruithofa
approved these changes
Sep 17, 2020
wopu-ot
added a commit
to wopu-ot/EDTT
that referenced
this pull request
Oct 1, 2021
[LL.TS.p18r64] Update naming convention in CIS/PER/* test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues discovered in the EDTT tests.