Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use docker compose v2 #163

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Commits on Feb 15, 2024

  1. use docker compose v2

    docker compose v2 is part of Docker nowadays. Rather than calling
    a separate Python lib that calls `docker-compose`, call `docker compose`
    and use v2.
    Fix the `-` and `_` difference between v1 and v2.
    This will need THOROUGH testing
    
    PFM-827
    fmcwalters-edited committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    a361a02 View commit details
    Browse the repository at this point in the history
  2. linting

    fmcwalters-edited committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    7cda8d3 View commit details
    Browse the repository at this point in the history
  3. use new form of network config

    the old type, `network.external.name` is deprecated on v2. It still works
    but it may be removed in future. Change to new format. See:
    docker-archive/compose-cli#1856
    fmcwalters-edited committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f6c595e View commit details
    Browse the repository at this point in the history
  4. remove version check and print statements

    this code will only ever be used in this version of the tool, and the
    `__version__` only checks the version of the _tool_ anyways.
    
    Also remove redundant print statements
    fmcwalters-edited committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    a439c4c View commit details
    Browse the repository at this point in the history
  5. convert v1 container names to v2

    if we create a container using compose v1 and we want to use or remove it
    using compose v2, we will need to convert its name to use the new format
    fmcwalters-edited committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    03fee73 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. deal with cases where container name has more than one middle name

    there are times where the container name consists of multiple names or
    a name and then a number; for example, composename-container-name-1-1.
    We want to keep only `container-name-1`. Ensure this is possible
    fmcwalters-edited committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b2958d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. use v14.0.0 for Kubetools with Docker Compose v2, update README

    Use the most logical version number for the next major version of this.
    
    This version of Kubetools introduces some unavoidable breaking changes
    that we can work around. Document these in the README.
    fmcwalters-edited committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    70ed8ef View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. readme formatting

    fmcwalters-edited committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    696efb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc59bbf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a4c3fe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    add0755 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f594288 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. improve documentation

    add incompatible version of Docker Desktop to CHANGELOG and add more detail
    to README as to why we need to be careful with this update
    fmcwalters-edited committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    eb53740 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    9ff20c1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e7b32c View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. make workarounds more descriptive

    suggest migrating to secure Docker registries, reword the suggestion to use the legacy builder
    
    Co-authored-by: Germain Chazot <[email protected]>
    fmcwalters-edited and gchazot authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4da3de5 View commit details
    Browse the repository at this point in the history
  2. factor out code to convert container names, add unit tests

    make the code easier to test by moving the name conversion into its
    own function and add test coverage
    
    also add test coverage for `dockerise_label`
    fmcwalters-edited committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b9cc5a4 View commit details
    Browse the repository at this point in the history
  3. improve documentation for buildx issue, make CHANGELOG more concise

    add `TROUBLESHOOTING` section to README to document the issue with
    `insecure-registries` and link this to ticket which is open and relevant,
    for `buildx`.
    
    remove anything from the CHANGELOG which belongs here
    fmcwalters-edited committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7a8b920 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Configuration menu
    Copy the full SHA
    bddb7ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    700658a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    2a39579 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f3b1bf View commit details
    Browse the repository at this point in the history