eddn: Address EDDN server complains about some codexentry messages #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Log the type of unexpected values. * Say 'falsey' not 'None' when we only `if not ...`
As it was we'd blindly set codexentry['BodyName'] from it if not None.
Athanasius
changed the title
|
I'm still pondering tweaking this some to not send any message that's found to have empty strings just before queueing it up. Ideally this can then set status text to alert the user: |
|
That works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still can't explicitly explain what causes these errors. All my example events have all the correct data. So this turned into tracing the code and adding some more paranoid checks and logging.
Closing #1393