Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPI: Cross-check /market id with Docked/Location marketID #1572

Closed
Athanasius opened this issue Jun 3, 2022 · 1 comment
Closed

CAPI: Cross-check /market id with Docked/Location marketID #1572

Athanasius opened this issue Jun 3, 2022 · 1 comment
Labels
bug CAPI Issues relating to CAPI support EDDN unconfirmed An unconfirmed bug

Comments

@Athanasius
Copy link
Contributor

Gazelle has noted that sometimes we see things like:

{
  "$schemaRef": "https://eddn.edcd.io/schemas/commodity/3",
  "header": {
    "gatewayTimestamp": "2022-06-02T07:37:23.195861Z",
    "softwareName": "E:D Market Connector [Windows]",
    "softwareVersion": "5.3.4",
    "uploaderID": "90010da415f63347f967a0245df7607e2d16c47b"
  },
  "message": {
    "commodities": [],
    "economies": [
      {
        "name": "HighTech",
        "proportion": 0.67
      },
      {
        "name": "Industrial",
        "proportion": 0.33
      }
    ],
    "horizons": true,
    "marketId": 128666762,
    "odyssey": true,
    "stationName": "The Champion of Piety",
    "systemName": "Crucis Sector EQ-Y b4",
    "timestamp": "2022-06-02T07:37:22Z"
  }
}

which has the wrong marketId for that station name, which is a MegaShip. That station is actually Jameson Memorial (according to spansh.co.uk).

So, we should probably also cross-check the Docked/Location marketID with the id returned by CAPI.

@Athanasius
Copy link
Contributor Author

Should be fixed in just released 5.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CAPI Issues relating to CAPI support EDDN unconfirmed An unconfirmed bug
Projects
None yet
Development

No branches or pull requests

1 participant