Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ECP-PI #66

Merged
merged 4 commits into from
Feb 15, 2019
Merged

Add support for ECP-PI #66

merged 4 commits into from
Feb 15, 2019

Conversation

junghans
Copy link
Member

@junghans junghans requested review from dalg24 and sslattery January 24, 2019 22:06
@ginsburgnm
Copy link

@junghans
Looks reasonable to me for build purposes, I just want to make sure you're aware, none of these jobs will submit to the LSF scheduler. as they are tagged "nobatch". It looks like it's all build anyway though, so it probably makes sense that you are not submitting to the scheduler yet.

This means though: SCHEDULER_PARAMETERS: "-P STF002 -J ginsburgtest -W 0:03 -nnodes 2"
will be ignored. It's fine if you want to keep it there for reference to when you do want to submit to the scheduler; but, you will need to change the project name ( -P STF002 ) that you are charging(as it will be rejected if you attempt to charge to that project). You should probably change the job name ( -J ginsburgtest ) to something more meaningful to you as my name probably isn't too helpful. -W 0:03 is walltime of 3 minutes, which probably will not suffice for real runs, but for short circuit testing is probably useful. -nnodes is number of nodes, so I have no opinion on what is appropriate for your team.

glad this is looking to be helpful to you; let me know if/when you run into strange things 👍

@junghans
Copy link
Member Author

@ginsburgnm, thanks for pointing that out, @sslattery and I will enable the mpi tests soon. These will run as batch.

@junghans
Copy link
Member Author

ping @sslattery

make -j${j} &&
make install &&
popd &&
popd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you chose to use pushd and popd rather than cd? You don't seem to take any advantage of being able to return to the paths in the directory stack. Or am I missing something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my personal preference, plus I like that it shows what directory I am in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #66   +/-   ##
======================================
  Coverage    97.7%   97.7%           
======================================
  Files          17      17           
  Lines        1097    1097           
======================================
  Hits         1072    1072           
  Misses         25      25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0e80c...be0bdad. Read the comment docs.

@junghans
Copy link
Member Author

@dalg24 please review!

@junghans junghans merged commit 6b79451 into ECP-copa:master Feb 15, 2019
@junghans junghans deleted the ecp-ci branch February 15, 2019 16:47
@dalg24
Copy link
Collaborator

dalg24 commented Feb 15, 2019

@junghans pipeline is stuck on onrl mirror repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants