-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ECP-PI #66
Conversation
@junghans This means though: glad this is looking to be helpful to you; let me know if/when you run into strange things 👍 |
@ginsburgnm, thanks for pointing that out, @sslattery and I will enable the mpi tests soon. These will run as |
ping @sslattery |
make -j${j} && | ||
make install && | ||
popd && | ||
popd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you chose to use pushd
and popd
rather than cd
? You don't seem to take any advantage of being able to return to the paths in the directory stack. Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my personal preference, plus I like that it shows what directory I am in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
======================================
Coverage 97.7% 97.7%
======================================
Files 17 17
Lines 1097 1097
======================================
Hits 1072 1072
Misses 25 25 Continue to review full report at Codecov.
|
@dalg24 please review! |
@junghans pipeline is stuck on onrl mirror repo. |
/cc @tgamblin @ginsburgnm @dnic