Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Reorganize the finite difference advance #5408

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

dpgrote
Copy link
Member

@dpgrote dpgrote commented Oct 22, 2024

The intent of this PR is to push the geometry related code down to the lowest level, so that it only appears in the files in the FiniteDifferenceAlgorithms directory. This is done by writing the code in terms of the differential operators, i.e. curl and gradient rather than the specific derivatives.

Status:

  • Implement the nodal curl for EvolveE
  • Add call to correct Etheta on axis for RZ (fixing possible bug)
  • Implement the cell-centered curl for EvolveB
  • Implement the gradient for the F advance
  • Implement the divergence for the G advance
  • Remove EvolveECylindrical
  • Remove EvolveBCylindrical
  • Remove unneeded n_coefs_ arguments
  • Make parent class for Cartesian algorithms for common operators

@dpgrote dpgrote added the component: FDTD FDTD solvers label Oct 22, 2024
@dpgrote dpgrote marked this pull request as ready for review October 24, 2024 00:00
@dpgrote dpgrote changed the title Reorganize the finite difference advance [WIP]Reorganize the finite difference advance Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: FDTD FDTD solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant