fields.py relies on MultiFab global indexing #5407
Open
+308
−697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…netic_reconnection_picmi.py
…_callback_picmi.py`
The previous case seemed to be suffering from the bug in the MultiFab global indexing that would sometimes use ghost cells instead of valid cell values. This is now fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global indexing capability for MultiFabs was moved to pyamrex. This PR deletes the now not needed code from WarpX, relying on the capability in pyamrex.
Note that the MultiFab wrapper is maintained since it is persistent across load balancing, while the underlying MultiFabs are deleted and regenerated.
This is an API breaking change since there are differences in how to access the ghost cells when using the global indexing.