Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADIOS2: Fix BTD Particle Resize w/ Empty Ranks #3657

Merged
merged 3 commits into from
Feb 2, 2023
Merged

ADIOS2: Fix BTD Particle Resize w/ Empty Ranks #3657

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc3cc55
ADIOS2: Fix BTD Resize w/ Empty Ranks
ax3l Jan 31, 2023
82440ca
[Draft] Start Duplicating All Put Logic
ax3l Feb 1, 2023
d1967a5
Better Work-Around
ax3l Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Source/Diagnostics/WarpXOpenPMD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,16 @@ WarpXOpenPMDPlot::DumpToFile (ParticleContainer* pc,

// Do not call storeChunk() with zero-sized particle tiles:
// https://github.com/openPMD/openPMD-api/issues/1147
if (numParticleOnTile == 0) continue;
// https://github.com/ECP-WarpX/WarpX/pull/1898#discussion_r745008290
// unless we append in ADIOS2:
// https://github.com/ECP-WarpX/WarpX/issues/3389
// https://github.com/ornladios/ADIOS2/issues/3455
// BP4 (ADIOS 2.8): last MPI rank's `Put` meta-data wins
// BP5 (ADIOS 2.8): everyone has to write an empty block
bool write_empty_blocks = false;
if (m_Series->backend() == "ADIOS2")
write_empty_blocks = isBTD;
if (numParticleOnTile == 0 && !write_empty_blocks) continue;
ax3l marked this conversation as resolved.
Show resolved Hide resolved

// get position and particle ID from aos
// note: this implementation iterates the AoS 4x...
Expand Down