Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new option <diag>.openpmd_encoding #1979

Merged
merged 10 commits into from
May 28, 2021
Merged

Added new option <diag>.openpmd_encoding #1979

merged 10 commits into from
May 28, 2021

Conversation

guj
Copy link
Contributor

@guj guj commented May 24, 2021 •
edited
Loading

which can be either f/g/v for file/group/variable

With the encoding being either "group" or "variable", one file will be generated for all
iterations. While if the encoding value is "file", each iteration will generate its own file.

Added new option <diag>.openpmd_encoding, which can be either file/gr…
8430ead 
…oup/variable

With the encoding being group/variable, there will be one file generated for all
iterations.
@guj guj changed the title Added new option <diag>.openpmd_encoding, which can be either file/gr… Added new option <diag>.openpmd_encoding, May 24, 2021
@ax3l ax3l self-requested a review May 24, 2021 17:49
@ax3l ax3l mentioned this pull request May 24, 2021
Closed
ax3l
ax3l reviewed May 24, 2021
View reviewed changes
Docs/source/usage/parameters.rst Show resolved Hide resolved
Source/Diagnostics/FlushFormats/FlushFormatOpenPMD.cpp Show resolved Hide resolved
Source/Diagnostics/WarpXOpenPMD.cpp Outdated Show resolved Hide resolved
Source/Diagnostics/WarpXOpenPMD.cpp Outdated Show resolved Hide resolved
Source/Diagnostics/WarpXOpenPMD.cpp Outdated Show resolved Hide resolved
Source/Diagnostics/WarpXOpenPMD.cpp Outdated Show resolved Hide resolved
Source/Diagnostics/FlushFormats/FlushFormatOpenPMD.cpp Show resolved Hide resolved
@ax3l ax3l changed the title Added new option <diag>.openpmd_encoding, Added new option <diag>.openpmd_encoding May 24, 2021
@ax3l ax3l self-assigned this May 24, 2021
@ax3l ax3l added the component: openPMD openPMD I/O label May 24, 2021
@ax3l ax3l added the enhancement New feature or request label May 24, 2021
@guj guj closed this May 25, 2021
@guj guj reopened this May 25, 2021
@ax3l
Copy link
Member

ax3l commented May 25, 2021

Leftover CI issue: for the qed_breit_wheeler_2d_opmd test, the analysis script analysis_opmd.py has to replace the line:

series = io.Series(prefix+"/openpmd_%T.h5", io.Access.read_only)

with

series = io.Series(prefix+"/openpmd.h5", io.Access.read_only)

@guj
Copy link
Contributor Author

guj commented May 25, 2021

Leftover CI issue: for the qed_breit_wheeler_2d_opmd test, the analysis script analysis_opmd.py has to replace the line:

series = io.Series(prefix+"/openpmd_%T.h5", io.Access.read_only)

with

series = io.Series(prefix+"/openpmd.h5", io.Access.read_only)

Thanks, I changed the default behavior to file based, and CI passed.

@ax3l ax3l added the changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults label May 28, 2021
@ax3l
Copy link
Member

ax3l commented May 28, 2021

Thanks, I changed the default behavior to file based, and CI passed.

Perfect, now we just need to update the docs. Will do & merge

ax3l
ax3l approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Wuhu! :)

@ax3l
Copy link
Member

ax3l commented May 28, 2021

Re-starting due to CI issue on Azure today

@ax3l ax3l closed this May 28, 2021
@ax3l ax3l reopened this May 28, 2021
@ax3l
Copy link
Member

ax3l commented May 28, 2021 •
edited
Loading

Since CI passed already and we just changed docs, I will merge this in already.
Azure has a hard day today: https://status.dev.azure.com/

@ax3l ax3l merged commit d2b2304 into ECP-WarpX:development May 28, 2021
@ax3l ax3l mentioned this pull request Jul 30, 2021
Merged
@ax3l ax3l mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults component: openPMD openPMD I/O enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guj @ax3l