Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

認可リクエスト画面の改善 #78

Merged
merged 1 commit into from
Aug 4, 2020
Merged

認可リクエスト画面の改善 #78

merged 1 commit into from
Aug 4, 2020

Conversation

kiy0taka
Copy link
Contributor

@kiy0taka kiy0taka commented Aug 3, 2020 •
edited
Loading

  • デザインを調整しました
    image

  • 「許可しない」を選んだ場合は、仕様に従ってエラーレスポンス(error=access_denied)をコールバックURLに返すようにしました

ref #44

@kiy0taka kiy0taka linked an issue Aug 3, 2020 that may be closed by this pull request
認可確認画面のデザインの改善 #44
Closed
@okazy okazy added the enhancement New feature or request label Aug 3, 2020
@okazy okazy added this to the 1.0 milestone Aug 3, 2020
@okazy
Copy link
Contributor

okazy commented Aug 4, 2020

問題なく動作することを確認しました。

image

許可しないを選択でerror=access_deniedが帰ってくることも確認済みです。

okazy
okazy approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@okazy okazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ソースコードも問題ありません。

@okazy okazy merged commit 41a3ba5 into EC-CUBE:master Aug 4, 2020
@okazy
Copy link
Contributor

okazy commented Aug 4, 2020

ありがとうございます！取り込みました。

@okazy okazy mentioned this pull request Aug 5, 2020
Open
@kiy0taka kiy0taka deleted the dev/auth_twig branch August 19, 2020 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okazy okazy okazy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

認可確認画面のデザインの改善
2 participants
@kiy0taka @okazy