Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix if 閉じタグの消し漏れ #973

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

clicktx
Copy link
Contributor

@clicktx clicktx commented Aug 6, 2024

#972の修正漏れがありました。インデントがズレていたのは気になっていたのですが...

@nanasess nanasess enabled auto-merge August 6, 2024 03:12
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (523d82e) to head (b699e8d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #973   +/-   ##
=======================================
  Coverage   55.63%   55.63%           
=======================================
  Files          75       75           
  Lines        8917     8917           
=======================================
  Hits         4961     4961           
  Misses       3956     3956           
Flag Coverage Δ
tests 55.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess
Copy link
Contributor

nanasess commented Aug 6, 2024

すみません。ありがとうございます🙇‍♂️

@nanasess nanasess merged commit 6debaf4 into EC-CUBE:master Aug 6, 2024
90 checks passed
@clicktx clicktx deleted the fix/remove-module-code-in-template branch August 17, 2024 04:11
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants