Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarty::addPluginsDir() は非推奨になったため、Smarty::registerPlugin() を使用するよう修正 #946

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jun 18, 2024

@nanasess nanasess force-pushed the replace-addPluginsDir branch from 89096ff to 443dd2d Compare June 19, 2024 07:37
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.72%. Comparing base (868c729) to head (d1202bd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
+ Coverage   55.69%   55.72%   +0.03%     
==========================================
  Files          75       75              
  Lines        8906     8913       +7     
==========================================
+ Hits         4960     4967       +7     
  Misses       3946     3946              
Flag Coverage Δ
tests 55.72% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess marked this pull request as ready for review June 19, 2024 08:20
@nanasess nanasess enabled auto-merge June 19, 2024 08:21
Copy link
Contributor

@seasoftjapan seasoftjapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作は問題無さそうです。ドキュメントで気になった点があるので、別途コメントします。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data/class/SC_View.php への追記についても言及した方が良さそうに思いますが、いかがでしょうか?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。こちらも記載しておきますね

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seasoftjapan 対応しました!

@nanasess nanasess merged commit 3c70f3c into EC-CUBE:master Jul 29, 2024
90 checks passed
@nanasess nanasess deleted the replace-addPluginsDir branch July 29, 2024 14:54
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smarty modifier に array_key_exists を追加
2 participants