Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yml version削除 #942

Conversation

seasoftjapan
Copy link
Contributor

記述があると WARN ... `version` is obsolete となるので。

- 記述があると `WARN ... `version` is obsolete` となるので。
@seasoftjapan seasoftjapan added this to the 2.17.3 milestone Jun 14, 2024
@seasoftjapan seasoftjapan requested a review from nanasess June 14, 2024 15:46
@seasoftjapan seasoftjapan self-assigned this Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.69%. Comparing base (af3bc8c) to head (a394ccf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #942   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files          75       75           
  Lines        8905     8905           
=======================================
  Hits         4960     4960           
  Misses       3945     3945           
Flag Coverage Δ
tests 55.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess enabled auto-merge June 15, 2024 13:36
Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess nanasess merged commit 06a5e80 into EC-CUBE:master Jun 15, 2024
90 checks passed
@nanasess
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants