Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smarty/smarty from 4.4.1 to 5.0.2 #876

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Bumps smarty/smarty from 4.4.1 to 5.0.2.

Release notes

Sourced from smarty/smarty's releases.

v5.0.2

What's Changed

Full Changelog: smarty-php/smarty@v5.0.1...v5.0.2

v5.0.1

  • Fix error in Smarty\Smarty::compileAllTemplates() by including missing FilesystemIterator class #966

Full Changelog: smarty-php/smarty@v5.0.0...v5.0.1

v5.0.0

What's Changed

New Contributors

Full Changelog: smarty-php/smarty@v4.5.1...v5.0.0

v5.0.0-rc3

What's Changed

New Contributors

Full Changelog: smarty-php/smarty@v5.0.0-rc2...v5.0.0-rc3

v5.0.0-rc2

What's Changed

... (truncated)

Changelog

Sourced from smarty/smarty's changelog.

[5.0.2] - 2024-03-28

  • Fix Smarty::assign() not returning $this when called with an array as first parameter #972

[5.0.1] - 2024-03-27

  • Fix error in Smarty\Smarty::compileAllTemplates() by including missing FilesystemIterator class #966

[5.0.0] - 2024-03-25

  • Fixed that scoped variables would overwrite parent scope #952
  • Removed publicly accessible $tpl->_var_stack variable

Fixed

  • Too many shorthand attributes error when using a modifier as a function with more than 3 parameters in an expression #949

Removed

  • Dropped support for undocumented {time()} added in v5.0.0 since we already have the documented {$smarty.now}

[5.0.0-rc3] - 2024-02-26

Added

  • PHP8.3 support #925
  • Backlink to GitHub in docs
  • Explain how to do escaping and set-up auto-escaping in docs #865
  • Link to variable scope page in the documentation for the assign tag #878
  • Add support for implode, substr and json_encode as modifiers/functions in templates #939
  • Add template path to CompilerException to enable rich debug features #935

Fixed

  • The {debug} tag was broken in v5 #922
  • Documentation on {if $x is even by $y} syntax
  • Fix incorrect compilation of expressions when escape_html=true #930

[5.0.0-rc2] - 2023-11-11

Fixed

  • Registered output filters wouldn't run #899
  • Use of negative numbers in {math} equations #895
  • Do not auto-html-escape custom function results #906
  • Fix case-sensitive tag names #907

Removed

  • Removed $smarty->registered_filters array

[5.0.0-rc1] - 2023-08-08

Added

  • Added support for PHP8.2
  • Added a new way to extend Smarty functionality using Smarty::addExtension() or Smarty::setExtensions(). Please see the docs for more information.

... (truncated)

Commits
  • bbd09c7 Merge branch 'release/5.0.2' into support/5
  • 52dc8ad version bump
  • 6f054ec Fix Smarty::assign() not returning when called with an array as first parame...
  • 4fec27c fix release tooling to support/5 branch
  • fea0d02 version bump
  • 4efa427 Fix missing and bogus use lines in src/Smarty.php. (#970)
  • 30b1c5b Deprecation fix for providing a non string value to ctype_digit (#960)
  • 3f871f9 Fix docblock information after Smarty 5 namespace changes (#968)
  • e161bab Merge branch 'release/5.0.0'
  • f8e63fc version bump
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [smarty/smarty](https://github.com/smarty-php/smarty) from 4.4.1 to 5.0.2.
- [Release notes](https://github.com/smarty-php/smarty/releases)
- [Changelog](https://github.com/smarty-php/smarty/blob/v5.0.2/CHANGELOG.md)
- [Commits](smarty-php/smarty@v4.4.1...v5.0.2)

---
updated-dependencies:
- dependency-name: smarty/smarty
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Apr 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.69%. Comparing base (51609ef) to head (0352f28).

Files Patch % Lines
data/class/SC_InstallView.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
+ Coverage   55.67%   55.69%   +0.02%     
==========================================
  Files          75       75              
  Lines        8900     8905       +5     
==========================================
+ Hits         4955     4960       +5     
  Misses       3945     3945              
Flag Coverage Δ
tests 55.69% <90.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess
Copy link
Contributor

nanasess commented Apr 2, 2024

要検証

@nanasess
Copy link
Contributor

nanasess commented Apr 5, 2024

@nobuhiko @seasoftjapan
手元の環境では以下の修正で9割程度動作するようになりましたので、念のためレビューいただけると助かります。
2b7468d

以下 public メソッド引数の Smarty_Internal_Template\Smarty\Template に変更されていますが、プラグインや決済モジュール、独自カスタマイズ箇所で直接呼ばれることはほとんど無いと思われるため、許容できると思っています。

  • prefilter_transform
  • outputfilter_transform
  • getCurrentTemplateFile

また、 function.html_radios_ex.php は動作しなくなりましたので削除しました

@nanasess nanasess force-pushed the dependabot/composer/smarty/smarty-5.0.2 branch from 4059be1 to 662aac4 Compare April 5, 2024 14:42
@nanasess nanasess force-pushed the dependabot/composer/smarty/smarty-5.0.2 branch from 5f96006 to 2b7468d Compare April 5, 2024 17:26
@nanasess nanasess enabled auto-merge April 21, 2024 12:27
@nanasess nanasess merged commit 30683bc into master Apr 21, 2024
91 checks passed
@dependabot dependabot bot deleted the dependabot/composer/smarty/smarty-5.0.2 branch April 21, 2024 13:12
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants