phpstan 調整 #842
Merged
phpstan 調整 #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- excludePaths の指定を (暗黙の analyseAndScan ではなく) analyse に限定する。 - 若干メモリー消費が多くなると思われる。支障があれば、analyseAndScan で良いと思うが後項のような検出漏れを生じるかも。 - 前項の変更に伴い新たに検出された、エラー `Class SC_SiteView constructor invoked with 1 parameter, 0 required.` を回避する。c893462a51a996a873a2f508766a3472271a1680 で削除されている引数が指定されていたもの。 - 前項の変更に伴い新たに検出されなくなった、エラーを ignoreErrors から削除する。 - excludePaths/analyseAndScan で、Smarty キャッシュは拡張子で指定する。インストラーのキャッシュも除外される。 - 1973616 で追記した bootstrapFiles の定義が不要となった様子なので削除する。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class SC_SiteView constructor invoked with 1 parameter, 0 required.を回避する。c893462a51a996a873a2f508766a3472271a1680 で削除されている引数が指定されていたもの。