Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#385 のPHP8対応、PHP5対応、軽微な修正、テスト調整 #824

Merged
merged 4 commits into from
Jan 31, 2024
Merged

#385 のPHP8対応、PHP5対応、軽微な修正、テスト調整 #824

merged 4 commits into from
Jan 31, 2024
+22 −183

Commits on Jan 28, 2024

  1. function の static 宣言漏れを修正

    @seasoftjapan
    seasoftjapan committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    fd1bd3b View commit details
    Browse the repository at this point in the history

  2. SC_Helper_DB::sfGetBasisDataCache() のテストを一部変更した 

    - #385 で追加した店舗基本情報をDBから取得する関数と比較する。
- 前項に伴い、Mock を使う必要がなくなり、削除した。
- Mock のデータが旧バージョンのカラムだったので見逃されていた不整合を修正した。
    @seasoftjapan
    seasoftjapan committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    2f78828 View commit details
    Browse the repository at this point in the history

  3. ebd413b で誤って追加した引数を削除

    @seasoftjapan
    seasoftjapan committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    1f65f2f View commit details
    Browse the repository at this point in the history

  4. PHP5 互換に修正

    @seasoftjapan
    seasoftjapan committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    68c64ad View commit details
    Browse the repository at this point in the history