Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarty html_checkboxes_ex html_radios_ex を廃止 #815 #817

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

seasoftjapan
Copy link
Contributor

@seasoftjapan seasoftjapan commented Jan 6, 2024

Fixed #815

@seasoftjapan seasoftjapan linked an issue Jan 6, 2024 that may be closed by this pull request
@seasoftjapan seasoftjapan added this to the 2.17.3 milestone Jan 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c438132) 55.33% compared to head (1973616) 55.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files          75       75           
  Lines        8902     8902           
=======================================
  Hits         4926     4926           
  Misses       3976     3976           
Flag Coverage Δ
tests 55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotani1111 dotani1111 merged commit f799ac4 into EC-CUBE:master Jan 17, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smarty html_checkboxes_ex html_radios_ex を廃止
4 participants