Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC_Helper_HandleError で定義前の ERROR_LOG_REALFILE が使われることがある #808 #809

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

seasoftjapan
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c438132) 55.33% compared to head (5a7a693) 55.36%.

Files Patch % Lines
data/class/helper/SC_Helper_HandleError.php 28.57% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
+ Coverage   55.33%   55.36%   +0.02%     
==========================================
  Files          75       75              
  Lines        8902     8901       -1     
==========================================
+ Hits         4926     4928       +2     
+ Misses       3976     3973       -3     
Flag Coverage Δ
tests 55.36% <28.57%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ji-eunsoo ji-eunsoo merged commit 14a4cb0 into EC-CUBE:master Jan 24, 2024
57 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SC_Helper_HandleError で定義前の ERROR_LOG_REALFILE が使われることがある
4 participants