Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

規格1の存在チェックが正しく行われるよう修正 #530

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

pineray
Copy link
Contributor

@pineray pineray commented Mar 16, 2022

商品IDに紐づく商品規格の取得ルーチンにおいて、商品規格1の存在チェックが適切に行われていないので修正しました。

@codecov-commenter
Copy link

Codecov Report

Merging #530 (c3094a1) into master (4b76107) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files          76       76           
  Lines        9039     9039           
=======================================
  Hits         4918     4918           
  Misses       4121     4121           
Flag Coverage Δ
tests 54.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/SC_Product.php 57.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b76107...c3094a1. Read the comment docs.

@kiy0taka kiy0taka merged commit 1cb56c7 into EC-CUBE:master Mar 16, 2022
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants