Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#274 リファクタ #528

Merged
merged 1 commit into from
Mar 16, 2022
Merged

#274 リファクタ #528

merged 1 commit into from
Mar 16, 2022

Conversation

nobuhiko
Copy link
Contributor

$productTypeId -> $product_type_id

@codecov-commenter
Copy link

Codecov Report

Merging #528 (504e458) into master (4b76107) will increase coverage by 0.13%.
The diff coverage is 97.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   54.40%   54.53%   +0.13%     
==========================================
  Files          76       76              
  Lines        9039     9065      +26     
==========================================
+ Hits         4918     4944      +26     
  Misses       4121     4121              
Flag Coverage Δ
tests 54.53% <97.59%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/helper/SC_Helper_Purchase.php 73.67% <97.05%> (+1.04%) ⬆️
data/class/SC_CartSession.php 95.94% <97.85%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b76107...504e458. Read the comment docs.

@kiy0taka kiy0taka merged commit 3129289 into EC-CUBE:master Mar 16, 2022
nanasess added a commit to nanasess/ec-cube2 that referenced this pull request Mar 22, 2022
[EC-CUBE#528](EC-CUBE#528) に伴う修正
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants