Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint のルール修正 #517

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Conversation

nanasess
Copy link
Contributor

  • ESLint を Prettier に依存しないよう修正
    • Prettier は柔軟なルール設定ができないため削除
    • Playwright 公式でも ESLint しか使ってない
  • yarn.lock との併用は非推奨なので package-lock.json を削除
  • Apply eslint --fix
  • Apply yarn webpack

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #517 (e0c009e) into master (1b23522) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files          76       76           
  Lines        9039     9039           
=======================================
  Hits         4918     4918           
  Misses       4121     4121           
Flag Coverage Δ
tests 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b23522...e0c009e. Read the comment docs.

@chihiro-adachi chihiro-adachi merged commit bf7d535 into EC-CUBE:master Feb 9, 2022
@chihiro-adachi
Copy link
Contributor

@nanasess
ありがとうございます、マージしました。

@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Feb 9, 2022
@nanasess nanasess deleted the fix-eslint branch October 3, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants