Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8対応 #405

Merged
merged 53 commits into from
Mar 11, 2021
Merged

PHP8対応 #405

merged 53 commits into from
Mar 11, 2021

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jun 19, 2020 •
edited
Loading

TODO

  • HTTP_Request の修正
  • Text_Password の修正
  • static 宣言した関数の精査
  • mdb2_driver_pgsql の修正
  • 廃止された関数の精査
  • PHPStan level:1 でのチェック

@okazy okazy added this to the 2.17.1 milestone Jun 23, 2020
@ryo-endo ryo-endo modified the milestones: 2.17.1, 2.17.2 Jun 29, 2020
nanasess added 25 commits July 1, 2020 13:05
@nanasess
Fix warnings
11e8d2e 
- `count(): Parameter must be an array or an object that implements Countable`
@nanasess
Merge pull request EC-CUBE#427 from nobuhiko/composer_update
2bef9fe 
composer update
@nanasess
Add defined
6818668
@nanasess
Fix warnings
df1d224
@nanasess
Merge pull request EC-CUBE#408 from nanasess/fix-countable
b8881c3 
[WIP] count() 関数の警告を修正
@nanasess
Merge pull request EC-CUBE#418 from nobuhiko/issue417
47ee12b 
グラフをGoogle Chartを使って描画する
@nanasess
Merge remote-tracking branch 'upstream/master' into static-testing
bf56fff
@nanasess
Fix fatal error on PHP8
b66e4b7
@nanasess
Fix fpdfi on PHP8
43383e4
@nanasess
use PHP8
cb448cb
@nanasess
Merge pull request EC-CUBE#429 from nanasess/fpdi-use-composer
b49ed41 
PDFのパッケージを Composer のものに変更
@nanasess
Add php8-compat
40dd99a
@nanasess
Fix static
0cedc08
@nanasess
Fix modifiers
07095e1
@nanasess
Add check to array
0bae925
@nanasess
static コールの修正
b48b481 
- see EC-CUBE#404 (comment)
@nanasess
Fix typo
b6ebed7
@nanasess
Add PHP8
1154756
@nanasess
static コールの修正
1d3663c 
- see EC-CUBE#404 (comment)
@nanasess
Fix typo
d52b8b5
@nanasess
Fix array_rand()
6b690e2 
> PHP Fatal error:  Uncaught ValueError: array_rand(): Argument #2 ($num) must be between 1 and the number of elements in argument #1 ($array) in ec-cube2/ctests/acceptance/_bootstrap.php:50
29
@nanasess
PHP5.6は含めない
4aed787
@nanasess
Fix constructor
cf6380f
@nanasess
Fix version number
a7e5496
@nanasess
PEAR::Text_Password に依存しないよう修正
e529276 
- PHP8 サポートされない可能性があるため
- openssl_random_pseudo_bytes() 関数で代用可能
@nanasess
Copy link
Contributor Author

PHPStan level:1 でエラー出ないようになりました。
スクリーンショット 2021-01-25 15 56 50

@nanasess nanasess mentioned this pull request Jan 25, 2021
Merged
@nanasess
Merge pull request EC-CUBE#440 from nanasess/fix-order-status
c90746a 
売上集計のE2Eテストが落ちるのを修正
@nanasess nanasess changed the title [WIP] PHP8対応 PHP8対応 Feb 24, 2021
@nanasess
Copy link
Contributor Author

Travis-CI, GitHub Actions ともにユニットテスト、 E2Eテストが通るのを確認しましたので WIP はずしました

@okazy okazy merged commit b47fc81 into EC-CUBE:master Mar 11, 2021
@okazy
Copy link
Contributor

okazy commented Mar 11, 2021

@nanasess ありがとうございます！取り込みました 🎉 🎉

@okazy okazy mentioned this pull request Mar 17, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2021
Closed
@chihiro-adachi chihiro-adachi mentioned this pull request Apr 19, 2022
Open
@nanasess nanasess deleted the static-testing branch October 3, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobuhiko nobuhiko nobuhiko approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.17.2
Development

Successfully merging this pull request may close these issues.

static メソッドの統一 PHP8対応
4 participants
@nanasess @okazy @nobuhiko @ryo-endo