Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LC_Page::plugin_activate_flg を非推奨に #286

Merged
merged 1 commit into from
Jul 2, 2019
Merged

LC_Page::plugin_activate_flg を非推奨に #286

merged 1 commit into from
Jul 2, 2019

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jun 26, 2019 •
edited
Loading

  • 75f3226 のコミットで常に true となっているため、LC_Page のメンバ変数は非推奨にして問題ない
  • SC_Helper_Plugin::getSingletonInstance() の引数のデフォルト値を PLUGIN_ACTIVATE_FLAG とするよう修正
  • 基本的に常に PLUGIN_ACTIVATE_FLAG の値を参照するよう修正
  • LC_Page::plugin_activate_flg の扱い #142

@nanasess
LC_Page::plugin_activate_flg を非推奨に
4d6793a 
- SC_Helper_Plugin::getSingletonInstance() の引数のデフォルト値を PLUGIN_ACTIVATE_FLAG とするよう修正
- 基本的に常に PLUGIN_ACTIVATE_FLAG の値を参照するよう修正
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 42.319% when pulling 4d6793a on nanasess:deprecated-plugin_activate_flg into 3ac54e0 on EC-CUBE:improve/php7.

@kazumiiiiiiiiiii kazumiiiiiiiiiii added this to the 2.17.0 milestone Jul 2, 2019
@kazumiiiiiiiiiii kazumiiiiiiiiiii merged commit 7f77a44 into EC-CUBE:improve/php7 Jul 2, 2019
@kazumiiiiiiiiiii
Copy link
Contributor

ありがとうございます！

@nanasess nanasess mentioned this pull request Oct 30, 2019
Closed
@nanasess nanasess deleted the deprecated-plugin_activate_flg branch October 3, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobuhiko nobuhiko nobuhiko approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nanasess @coveralls @kazumiiiiiiiiiii @nobuhiko