Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update appveyor.yml #213

Merged
merged 15 commits into from
Aug 16, 2018
Merged

update appveyor.yml #213

merged 15 commits into from
Aug 16, 2018

Conversation

nobuhiko
Copy link
Contributor

@nobuhiko nobuhiko commented Aug 8, 2018

動くけどテストは落ちる

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.435% when pulling 6b0e77b on nobuhiko:fix_appv into 8d71efa on EC-CUBE:improve/php7.

@okazy okazy added this to the 2.17.0 milestone Aug 14, 2018
@okazy
Copy link
Contributor

okazy commented Aug 14, 2018

appveyorが落ちてしまっている件の進め方について、
まずこのプルリクをマージしてappveyorが動くようにし、テスト自体は別途修正していくのが良いかと思います。

Approveをいただければこちらのプルリクをマージさせていただきます。

他のプルリクについてですが、appveyorのテストが通るようになるまでは、Approveとtravisが通ればマージする方針でいかがでしょうか。

他によい進め方があればよろしくお願いいたします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants