Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LC_Page_Admin_Products_Review empty() が残っている #789

Closed
seasoftjapan opened this issue Nov 2, 2023 · 0 comments · Fixed by #791
Closed

LC_Page_Admin_Products_Review empty() が残っている #789

seasoftjapan opened this issue Nov 2, 2023 · 0 comments · Fixed by #791
Assignees
@seasoftjapan

Comments

@seasoftjapan
Copy link
Contributor

関連 http://svn.ec-cube.net/open_trac/ticket/791

ec-cube2/data/class/pages/admin/products/LC_Page_Admin_Products_Review.php

Lines 252 to 255 in 1c32814

foreach ($arrForm AS $key=>$val) {
if (empty($val)) continue;
switch ($key) {

カスタマイズで ID:0 を扱ったらスルーされた。
seasoftjapan added a commit to seasoftjapan/eccube-2_13 that referenced this issue Nov 2, 2023
@seasoftjapan
LC_Page_Admin_Products_Review empty() が残っている EC-CUBE#789
b020e38
@seasoftjapan seasoftjapan self-assigned this Nov 2, 2023
@seasoftjapan seasoftjapan linked a pull request Jan 4, 2024 that will close this issue
LC_Page_Admin_Products_Review empty() が残っている #789 #791
Merged
ji-eunsoo added a commit that referenced this issue Jan 24, 2024
@ji-eunsoo
Merge pull request #791 from seasoftjapan/seasoft-789
9e3102f 
LC_Page_Admin_Products_Review empty() が残っている #789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seasoftjapan seasoftjapan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LC_Page_Admin_Products_Review empty() が残っている #789 seasoftjapan/eccube-2_13
1 participant
@seasoftjapan