Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions のワークフローでビルドしたイメージが取得できない #1019

Closed
nanasess opened this issue Oct 3, 2024 · 0 comments · Fixed by #1037
Closed

GitHub Actions のワークフローでビルドしたイメージが取得できない #1019

nanasess opened this issue Oct 3, 2024 · 0 comments · Fixed by #1037
Milestone
2.18(仮)

Comments

@nanasess
Copy link
Contributor

nanasess commented Oct 3, 2024

Pull Request の場合は github.base_ref=master になるため、 master ブランチのイメージを取得してしまう
https://github.com/EC-CUBE/ec-cube2/blob/master/.github/workflows/unit-tests.yml#L56

結果的に Dockerfile の変更が GitHub Actions に反映されない。
TAG=${DOCKER_METADATA_OUTPUT_VERSION} としたい
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18(仮)
Development

Successfully merging a pull request may close this issue.

Add PHP8.4-rc nanasess/ec-cube2
1 participant
@nanasess