-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
型定義の記述に誤りがあるものを修正 #6114
型定義の記述に誤りがあるものを修正 #6114
Conversation
@tominaga-h |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6114 +/- ##
=========================================
Coverage 82.76% 82.76%
Complexity 6514 6514
=========================================
Files 479 479
Lines 26035 26035
=========================================
Hits 21547 21547
Misses 4488 4488
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
テストが失敗しているのは、テスト画像のジェネレーション時に失敗しているようです。 |
@tominaga-h |
@dotani1111 |
@tominaga-h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
コメントのみの修正ですので問題ないと思います
概要(Overview・Refs Issue)
PHPDocにおける型定義の本来の記述は
ですが、
と記述している箇所があるため修正しました。
方針(Policy)
実装に関する補足(Appendix)
テスト(Test)
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目