注文時に支払い方法が非表示に変更された場合エラーが発生するよう修正 #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
suggested changes
Aug 17, 2022
|
|
||
| if ($itemHolder instanceof Order) { | ||
| // 支払い方法が非表示の場合はエラー | ||
| if (false === $itemHolder->getPayment()->isVisible()) { |
There was a problem hiding this comment.
@kurozumi
一部の決済プラグインや特定の条件によってはgetPayment()がnullを返すことがありますので、getPaymentのnullチェックをお願いできればありがたいです。
|
@chihiro-adachi |
Codecov Report
@@ Coverage Diff @@
## 4.2 #5558 +/- ##
============================================
+ Coverage 78.82% 78.84% +0.02%
- Complexity 6253 6258 +5
============================================
Files 469 469
Lines 20992 20999 +7
============================================
+ Hits 16547 16557 +10
+ Misses 4445 4442 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@kurozumi |
chihiro-adachi
approved these changes
Aug 18, 2022
chihiro-adachi
added
bugbounty2022:pr:testcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
以下のissueの対応です。
#5549
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目