Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] 独自プラグインのE2Eテストに @group restrict-fileupload を追加 #5436

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

nanasess
Copy link
Contributor

概要(Overview・Refs Issue)

closes #5432
独自プラグインのE2Eテストに @group restrict-fileupload を追加

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更はありません
  • フックポイントの呼び出しタイミングの変更はありません
  • フックポイントのパラメータの削除・データ型の変更はありません
  • twigファイルに渡しているパラメータの削除・データ型の変更はありません
  • Serviceクラスの公開関数の、引数の削除・データ型の変更はありません
  • 入出力ファイル(CSVなど)のフォーマット変更はありません

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか
    • 権限を超えた操作が可能にならないか
    • 不要なファイルアップロードがないか
    • 外部へ公開されるファイルや機能の追加ではないか
    • テンプレートでのエスケープ漏れがないか

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #5436 (fc95c50) into 4.2 (3c6c26a) will increase coverage by 24.47%.
The diff coverage is n/a.

❗ Current head fc95c50 differs from pull request most recent head 7efe798. Consider uploading reports for the commit 7efe798 to get more accurate results

@@              Coverage Diff              @@
##                4.2    #5436       +/-   ##
=============================================
+ Coverage     53.02%   77.49%   +24.47%     
- Complexity     6166     6232       +66     
=============================================
  Files           466      466               
  Lines         20959    20959               
=============================================
+ Hits          11113    16243     +5130     
+ Misses         9846     4716     -5130     
Flag Coverage Δ
E2E 49.49% <ø> (+<0.01%) ⬆️
Unit 76.92% <ø> (+65.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Eccube/EventListener/ExceptionListener.php 83.67% <0.00%> (-4.09%) ⬇️
src/Eccube/Twig/Extension/EccubeExtension.php 82.35% <0.00%> (+0.98%) ⬆️
src/Eccube/Util/CacheUtil.php 82.85% <0.00%> (+1.42%) ⬆️
...ntroller/Admin/Setting/Shop/DeliveryController.php 81.81% <0.00%> (+1.70%) ⬆️
src/Eccube/Entity/Member.php 85.56% <0.00%> (+2.06%) ⬆️
...Eccube/Controller/Admin/Content/FileController.php 87.13% <0.00%> (+2.07%) ⬆️
...ntroller/Admin/Customer/CustomerEditController.php 95.34% <0.00%> (+2.32%) ⬆️
...ccube/Controller/Admin/Content/BlockController.php 96.25% <0.00%> (+2.50%) ⬆️
src/Eccube/Form/Type/Admin/MainEditType.php 97.36% <0.00%> (+2.63%) ⬆️
...be/Controller/Admin/Product/CategoryController.php 86.61% <0.00%> (+2.81%) ⬆️
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6c26a...7efe798. Read the comment docs.

@kiy0taka
Copy link
Contributor

@nanasess GitHub Actionsの方では、restrict-fileupload ではなく、restrict-file-upload になっています。
https://github.com/EC-CUBE/ec-cube/blob/4.2/.github/workflows/e2e-test.yml#L24

@kiy0taka kiy0taka added the bug label Jul 13, 2022
@nanasess nanasess force-pushed the add-restrict-file-upload branch 2 times, most recently from fc95c50 to 7efe798 Compare July 13, 2022 08:13
@nanasess nanasess force-pushed the add-restrict-file-upload branch from 7efe798 to d8911dd Compare July 13, 2022 08:39
@nanasess
Copy link
Contributor Author

@kiy0taka ありがとうございます!いろいろミスってたので修正して動くようになりました
https://github.com/EC-CUBE/ec-cube/runs/7317617950?check_suite_focus=true

@chihiro-adachi chihiro-adachi added this to the 4.2.0 milestone Jul 13, 2022
@chihiro-adachi
Copy link
Contributor

@nanasess
ありがとうございます、カバレッジ復活しましたね!

@chihiro-adachi chihiro-adachi merged commit 26ce0d6 into EC-CUBE:4.2 Jul 13, 2022
@nanasess nanasess deleted the add-restrict-file-upload branch October 3, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants