コンテナビルド時にEC-CUBEを初期化せずに、コンテナ初回起動時に初期化する。 #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiy0taka
force-pushed
the
dev/initialize_on_first_startup
branch
from
ffde141 to
0a86761
Compare
|
初回起動時に初期化する方針賛成です。 私の環境(Windows + WSL + DockerDesktop)でも試行したのですが、MySQLとPostgresについては問題なく起動・初期処理を行えました。 MySQLec-cubeコンテナログ(MySQL/初回起動)docker compose -f docker-compose.yml -f docker-compose.mysql.yml logs ec-cubeec-cubeコンテナログ(MySQL/2度目の起動)docker compose -f docker-compose.yml -f docker-compose.mysql.yml logs ec-cubePostgresec-cubeコンテナログ(Postgres/初回起動)ec-cubeコンテナログ(2度目の起動)SQLite※起動エラー # ボリューム&コンテナ削除
docker compose -f docker-compose.yml down -v
# 初回起動
docker compose -f docker-compose.yml up -dec-cubeコンテナログ(SQLite/初回起動/エラー)環境OS: Windows11 プロジェクトフォルダ |
Codecov Report
@@ Coverage Diff @@
## 4.1 #5369 +/- ##
=========================================
Coverage 68.57% 68.58%
Complexity 6162 6162
=========================================
Files 463 463
Lines 25306 25306
=========================================
+ Hits 17354 17356 +2
+ Misses 7952 7950 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kiy0taka
force-pushed
the
dev/initialize_on_first_startup
branch
3 times, most recently
from
5472d9a to
848646f
Compare
kiy0taka
force-pushed
the
dev/initialize_on_first_startup
branch
from
848646f to
fc93eea
Compare
|
@m-pyon23 確認ありがとうございます！SQLiteでも問題ないように修正しました。 |
This was referenced Jun 15, 2022
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
コンテナビルド時に初期化する方法では、SQLiteのみしか初期化できない。
コンテナ初回起動時に初期化する方法にすれば、実行時に利用しているデータベースに合わせて初期化できる。
方針(Policy)
SKIP_INSTALL_SCRIPT_ON_DOCKER_BUILDを廃止。vendorディレクトリが空かどうかselect * from dtb_base_infoを実行できるかどうか実装に関する補足(Appendix)
テスト（Test)
ec-cubeコンテナ起動ログ
ec-cubeコンテナ起動ログ
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目