Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply composer update #5093

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Apply composer update #5093

merged 3 commits into from
Jul 21, 2021

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jul 19, 2021

概要(Overview・Refs Issue)

  • Removing php-coveralls/php-coveralls (v2.4.3)
  • Upgrading codeception/codeception (4.1.20 => 4.1.21)
  • Upgrading codeception/module-webdriver (1.2.0 => 1.2.1)
  • Upgrading composer/ca-bundle (1.2.9 => 1.2.10)
  • Upgrading composer/composer (2.0.12 => 2.1.3)
  • Locking composer/metadata-minifier (1.0.0)
  • Upgrading composer/package-versions-deprecated (1.11.99.1 => 1.11.99.2)
  • Upgrading composer/semver (3.2.4 => 3.2.5)
  • Upgrading composer/xdebug-handler (1.4.6 => 2.0.1)
  • Upgrading doctrine/annotations (1.12.1 => 1.13.1)
  • Upgrading doctrine/cache (1.10.2 => 1.12.0)
  • Upgrading doctrine/dbal (2.13.0 => 2.13.2)
  • Upgrading doctrine/inflector (1.3.1 => 1.4.4)
  • Upgrading friendsofphp/php-cs-fixer (v2.18.4 => v2.19.0)
  • Upgrading friendsofphp/proxy-manager-lts (v1.0.3 => v1.0.5)
  • Upgrading guzzlehttp/psr7 (1.8.1 => 1.8.2)
  • Upgrading monolog/monolog (1.26.0 => 1.26.1)
  • Upgrading nikic/php-parser (v4.10.4 => v4.11.0)
  • Upgrading php-webdriver/webdriver (1.10.0 => 1.11.1)
  • Upgrading phpstan/phpstan (0.12.91 => 0.12.92)
  • Upgrading psr/log (1.1.3 => 1.1.4)
  • Upgrading skorp/detect-incompatible-samesite-useragents (1.0.0 => 1.0.1)
  • Upgrading symfony/asset (v4.4.20 => v4.4.25)
  • Upgrading symfony/browser-kit (v4.4.20 => v4.4.25)
  • Upgrading symfony/cache (v4.4.21 => v4.4.26)
  • Upgrading symfony/config (v4.4.20 => v4.4.26)
  • Upgrading symfony/console (v4.4.21 => v4.4.26)
  • Upgrading symfony/css-selector (v4.4.20 => v4.4.25)
  • Upgrading symfony/debug (v4.4.20 => v4.4.25)
  • Upgrading symfony/dependency-injection (v4.4.21 => v4.4.26)
  • Upgrading symfony/deprecation-contracts (v2.2.0 => v2.4.0)
  • Upgrading symfony/doctrine-bridge (v4.4.21 => v4.4.25)
  • Upgrading symfony/dom-crawler (v4.4.20 => v4.4.25)
  • Upgrading symfony/dotenv (v4.4.20 => v4.4.25)
  • Upgrading symfony/error-handler (v4.4.21 => v4.4.26)
  • Upgrading symfony/event-dispatcher (v4.4.20 => v4.4.25)
  • Upgrading symfony/expression-language (v4.4.20 => v4.4.25)
  • Upgrading symfony/filesystem (v4.4.21 => v4.4.26)
  • Upgrading symfony/finder (v4.4.20 => v4.4.25)
  • Upgrading symfony/flex (v1.12.2 => v1.13.3)
  • Upgrading symfony/form (v4.4.21 => v4.4.26)
  • Upgrading symfony/framework-bundle (v4.4.21 => v4.4.26)
  • Upgrading symfony/http-foundation (v4.4.20 => v4.4.26)
  • Upgrading symfony/http-kernel (v4.4.21 => v4.4.26)
  • Upgrading symfony/inflector (v4.4.21 => v4.4.25)
  • Upgrading symfony/intl (v4.4.20 => v4.4.25)
  • Upgrading symfony/maker-bundle (v1.30.2 => v1.33.0)
  • Upgrading symfony/mime (v4.4.21 => v4.4.26)
  • Upgrading symfony/monolog-bridge (v4.4.21 => v4.4.26)
  • Upgrading symfony/options-resolver (v4.4.20 => v4.4.25)
  • Upgrading symfony/phpunit-bridge (v4.4.21 => v4.4.26)
  • Upgrading symfony/polyfill-ctype (v1.22.1 => v1.23.0)
  • Upgrading symfony/polyfill-iconv (v1.22.1 => v1.23.0)
  • Upgrading symfony/polyfill-intl-icu (v1.22.1 => v1.23.0)
  • Upgrading symfony/polyfill-intl-idn (v1.22.1 => v1.23.0)
  • Upgrading symfony/polyfill-intl-normalizer (v1.22.1 => v1.23.0)
  • Upgrading symfony/polyfill-mbstring (v1.22.1 => v1.23.0)
  • Upgrading symfony/polyfill-php72 (v1.22.1 => v1.23.0)
  • Upgrading symfony/polyfill-php73 (v1.22.1 => v1.23.0)
  • Upgrading symfony/polyfill-php80 (v1.22.1 => v1.23.0)
  • Locking symfony/polyfill-php81 (v1.23.0)
  • Upgrading symfony/process (v4.4.20 => v4.4.26)
  • Upgrading symfony/property-access (v4.4.20 => v4.4.25)
  • Upgrading symfony/proxy-manager-bridge (v4.4.20 => v4.4.25)
  • Upgrading symfony/routing (v4.4.20 => v4.4.25)
  • Upgrading symfony/security (v4.4.21 => v4.4.26)
  • Upgrading symfony/security-bundle (v4.4.21 => v4.4.26)
  • Upgrading symfony/serializer (v4.4.20 => v4.4.26)
  • Upgrading symfony/stopwatch (v4.4.20 => v4.4.25)
  • Upgrading symfony/templating (v4.4.20 => v4.4.25)
  • Upgrading symfony/translation (v4.4.21 => v4.4.26)
  • Upgrading symfony/twig-bridge (v4.4.21 => v4.4.26)
  • Upgrading symfony/twig-bundle (v4.4.20 => v4.4.26)
  • Upgrading symfony/validator (v4.4.21 => v4.4.26)
  • Upgrading symfony/var-dumper (v4.4.21 => v4.4.26)
  • Upgrading symfony/var-exporter (v4.4.20 => v4.4.26)
  • Upgrading symfony/web-profiler-bundle (v4.4.21 => v4.4.26)
  • Upgrading symfony/web-server-bundle (v4.4.21 => v4.4.26)
  • Upgrading symfony/workflow (v4.4.20 => v4.4.25)
  • Upgrading symfony/yaml (v4.4.21 => v4.4.26)

方針(Policy)

  • composer update を実行

実装に関する補足(Appendix)

以下の対応後、再度 composer update を実行します
EC-CUBE/eccube-plugin-installer#19

テスト(Test)

eccube-plugin-installer を修正した状態で GitHub Actions が通るのを確認

相談(Discussion)

bin/console コマンドのテストケースも作りたい

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

nanasess added 2 commits July 15, 2021 18:00
  - Removing php-coveralls/php-coveralls (v2.4.3)
  - Upgrading codeception/codeception (4.1.20 => 4.1.21)
  - Upgrading codeception/module-webdriver (1.2.0 => 1.2.1)
  - Upgrading composer/ca-bundle (1.2.9 => 1.2.10)
  - Upgrading composer/composer (2.0.12 => 2.1.3)
  - Locking composer/metadata-minifier (1.0.0)
  - Upgrading composer/package-versions-deprecated (1.11.99.1 => 1.11.99.2)
  - Upgrading composer/semver (3.2.4 => 3.2.5)
  - Upgrading composer/xdebug-handler (1.4.6 => 2.0.1)
  - Upgrading doctrine/annotations (1.12.1 => 1.13.1)
  - Upgrading doctrine/cache (1.10.2 => 1.12.0)
  - Upgrading doctrine/dbal (2.13.0 => 2.13.2)
  - Upgrading doctrine/inflector (1.3.1 => 1.4.4)
  - Upgrading friendsofphp/php-cs-fixer (v2.18.4 => v2.19.0)
  - Upgrading friendsofphp/proxy-manager-lts (v1.0.3 => v1.0.5)
  - Upgrading guzzlehttp/psr7 (1.8.1 => 1.8.2)
  - Upgrading monolog/monolog (1.26.0 => 1.26.1)
  - Upgrading nikic/php-parser (v4.10.4 => v4.11.0)
  - Upgrading php-webdriver/webdriver (1.10.0 => 1.11.1)
  - Upgrading phpstan/phpstan (0.12.91 => 0.12.92)
  - Upgrading psr/log (1.1.3 => 1.1.4)
  - Upgrading skorp/detect-incompatible-samesite-useragents (1.0.0 => 1.0.1)
  - Upgrading symfony/asset (v4.4.20 => v4.4.25)
  - Upgrading symfony/browser-kit (v4.4.20 => v4.4.25)
  - Upgrading symfony/cache (v4.4.21 => v4.4.26)
  - Upgrading symfony/config (v4.4.20 => v4.4.26)
  - Upgrading symfony/console (v4.4.21 => v4.4.26)
  - Upgrading symfony/css-selector (v4.4.20 => v4.4.25)
  - Upgrading symfony/debug (v4.4.20 => v4.4.25)
  - Upgrading symfony/dependency-injection (v4.4.21 => v4.4.26)
  - Upgrading symfony/deprecation-contracts (v2.2.0 => v2.4.0)
  - Upgrading symfony/doctrine-bridge (v4.4.21 => v4.4.25)
  - Upgrading symfony/dom-crawler (v4.4.20 => v4.4.25)
  - Upgrading symfony/dotenv (v4.4.20 => v4.4.25)
  - Upgrading symfony/error-handler (v4.4.21 => v4.4.26)
  - Upgrading symfony/event-dispatcher (v4.4.20 => v4.4.25)
  - Upgrading symfony/expression-language (v4.4.20 => v4.4.25)
  - Upgrading symfony/filesystem (v4.4.21 => v4.4.26)
  - Upgrading symfony/finder (v4.4.20 => v4.4.25)
  - Upgrading symfony/flex (v1.12.2 => v1.13.3)
  - Upgrading symfony/form (v4.4.21 => v4.4.26)
  - Upgrading symfony/framework-bundle (v4.4.21 => v4.4.26)
  - Upgrading symfony/http-foundation (v4.4.20 => v4.4.26)
  - Upgrading symfony/http-kernel (v4.4.21 => v4.4.26)
  - Upgrading symfony/inflector (v4.4.21 => v4.4.25)
  - Upgrading symfony/intl (v4.4.20 => v4.4.25)
  - Upgrading symfony/maker-bundle (v1.30.2 => v1.33.0)
  - Upgrading symfony/mime (v4.4.21 => v4.4.26)
  - Upgrading symfony/monolog-bridge (v4.4.21 => v4.4.26)
  - Upgrading symfony/options-resolver (v4.4.20 => v4.4.25)
  - Upgrading symfony/phpunit-bridge (v4.4.21 => v4.4.26)
  - Upgrading symfony/polyfill-ctype (v1.22.1 => v1.23.0)
  - Upgrading symfony/polyfill-iconv (v1.22.1 => v1.23.0)
  - Upgrading symfony/polyfill-intl-icu (v1.22.1 => v1.23.0)
  - Upgrading symfony/polyfill-intl-idn (v1.22.1 => v1.23.0)
  - Upgrading symfony/polyfill-intl-normalizer (v1.22.1 => v1.23.0)
  - Upgrading symfony/polyfill-mbstring (v1.22.1 => v1.23.0)
  - Upgrading symfony/polyfill-php72 (v1.22.1 => v1.23.0)
  - Upgrading symfony/polyfill-php73 (v1.22.1 => v1.23.0)
  - Upgrading symfony/polyfill-php80 (v1.22.1 => v1.23.0)
  - Locking symfony/polyfill-php81 (v1.23.0)
  - Upgrading symfony/process (v4.4.20 => v4.4.26)
  - Upgrading symfony/property-access (v4.4.20 => v4.4.25)
  - Upgrading symfony/proxy-manager-bridge (v4.4.20 => v4.4.25)
  - Upgrading symfony/routing (v4.4.20 => v4.4.25)
  - Upgrading symfony/security (v4.4.21 => v4.4.26)
  - Upgrading symfony/security-bundle (v4.4.21 => v4.4.26)
  - Upgrading symfony/serializer (v4.4.20 => v4.4.26)
  - Upgrading symfony/stopwatch (v4.4.20 => v4.4.25)
  - Upgrading symfony/templating (v4.4.20 => v4.4.25)
  - Upgrading symfony/translation (v4.4.21 => v4.4.26)
  - Upgrading symfony/twig-bridge (v4.4.21 => v4.4.26)
  - Upgrading symfony/twig-bundle (v4.4.20 => v4.4.26)
  - Upgrading symfony/validator (v4.4.21 => v4.4.26)
  - Upgrading symfony/var-dumper (v4.4.21 => v4.4.26)
  - Upgrading symfony/var-exporter (v4.4.20 => v4.4.26)
  - Upgrading symfony/web-profiler-bundle (v4.4.21 => v4.4.26)
  - Upgrading symfony/web-server-bundle (v4.4.21 => v4.4.26)
  - Upgrading symfony/workflow (v4.4.20 => v4.4.25)
  - Upgrading symfony/yaml (v4.4.21 => v4.4.26)
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #5093 (ffdfb36) into 4.1 (0a7b04f) will decrease coverage by 0.02%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.1    #5093      +/-   ##
============================================
- Coverage     75.72%   75.70%   -0.03%     
- Complexity     6025     6026       +1     
============================================
  Files           456      456              
  Lines         21142    21154      +12     
============================================
+ Hits          16010    16014       +4     
- Misses         5132     5140       +8     
Flag Coverage Δ
tests 75.70% <45.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Eccube/Controller/Admin/Order/EditController.php 79.54% <0.00%> (-0.92%) ⬇️
...ontroller/Admin/Setting/Shop/PaymentController.php 84.07% <0.00%> (-0.76%) ⬇️
src/Eccube/Service/Payment/Method/CreditCard.php 0.00% <0.00%> (ø)
src/Eccube/Twig/Template.php 62.50% <0.00%> (-8.93%) ⬇️
...c/Eccube/Controller/AbstractShoppingController.php 100.00% <100.00%> (ø)
src/Eccube/Controller/CartController.php 79.77% <100.00%> (+0.22%) ⬆️
src/Eccube/Controller/ShoppingController.php 51.30% <100.00%> (+0.15%) ⬆️
src/Eccube/Service/Payment/Method/Cash.php 100.00% <100.00%> (ø)
src/Eccube/Service/OrderPdfService.php 94.68% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7b04f...ffdfb36. Read the comment docs.

@okazy
Copy link
Contributor

okazy commented Jul 20, 2021

@okazy okazy added dependencies Pull requests that update a dependency file improvement 機能改善 labels Jul 20, 2021
@okazy okazy added this to the 4.1 milestone Jul 20, 2021
@okazy
Copy link
Contributor

okazy commented Jul 20, 2021

@nanasess
再度 composer update の実行をお願いできますでしょうか?

  - Upgrading doctrine/cache (1.12.0 => 1.12.1)
  - Upgrading ec-cube/plugin-installer (2.0.0 => 2.0.1)
  - Upgrading mikey179/vfsstream (v1.6.8 => v1.6.9)
  - Upgrading phpunit/php-file-iterator (2.0.3 => 2.0.4)
Copy link
Contributor

@okazy okazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

差分確認しました。
動作が変わりそうな変更はありませんでした。

@okazy okazy merged commit b51348f into EC-CUBE:4.1 Jul 21, 2021
@okazy
Copy link
Contributor

okazy commented Jul 21, 2021

ありがとうございます、マージしました。

@nanasess nanasess deleted the composer2.1-update branch October 3, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement 機能改善 Status: ready-for-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants