Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

規格・規格分類:「CSV登録」作成, 「CSVダウンロード・CSV出力項目設定」追加 #5043

Merged
merged 9 commits into from
Apr 12, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2021

概要(Overview・Refs Issue)

規格のCSV登録の要望がある為、実装

方針(Policy)

既存機能のカテゴリCSV登録を参考に実装

テスト(Test)

「規格・規格分類」CSV登録テスト
・新規, 変更登録の確認
・削除の確認
・商品規格へ設定されると削除できない事を確認

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@chihiro-adachi chihiro-adachi added this to the 4.1 milestone Aug 26, 2021
@chihiro-adachi chihiro-adachi added the enhancement 機能追加 label Aug 26, 2021
@chihiro-adachi chihiro-adachi modified the milestones: 4.1, 4.1.x Sep 3, 2021
@carkn carkn force-pushed the refine-kenshi/feature/class_csv branch from 8b3a43c to 1b463da Compare June 3, 2022 07:33
@chihiro-adachi chihiro-adachi changed the base branch from 4.0 to 4.1 June 3, 2022 07:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Attention: Patch coverage is 53.19149% with 132 lines in your changes are missing coverage. Please review.

Project coverage is 82.45%. Comparing base (ebec3e1) to head (9878731).

Files Patch % Lines
...e/Controller/Admin/Product/CsvImportController.php 72.41% 56 Missing ⚠️
...ntroller/Admin/Product/ClassCategoryController.php 2.50% 39 Missing ⚠️
...e/Controller/Admin/Product/ClassNameController.php 5.12% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              4.3    #5043      +/-   ##
==========================================
- Coverage   82.77%   82.45%   -0.32%     
==========================================
  Files         480      480              
  Lines       26062    26343     +281     
==========================================
+ Hits        21573    21722     +149     
- Misses       4489     4621     +132     
Flag Coverage Δ
E2E 82.45% <53.19%> (-0.32%) ⬇️
Unit 82.45% <53.19%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuelian311 xuelian311 modified the milestones: 4.1.x, 4.2.2 May 8, 2023
@carkn carkn modified the milestones: 4.2.2, 4.2.3 Jun 30, 2023
@dotani1111 dotani1111 modified the milestones: 4.2.3, 4.2.x Nov 10, 2023
@xuelian311 xuelian311 modified the milestones: 4.2.x, 4.3.0 Feb 21, 2024
@shinya shinya changed the base branch from 4.1 to 4.3 March 6, 2024 07:21
@shinya
Copy link
Contributor

shinya commented Mar 6, 2024

コードの最新化後、動作確認が必要。

@refine-kenshi
テストコードの追加をまたお時間有るときにお願いしたいです。
難しそうならこちらで巻き取ります。

@xuelian311
Copy link
Contributor

マージしても問題ない

@ji-eunsoo ji-eunsoo merged commit 80ebb2d into EC-CUBE:4.3 Apr 12, 2024
94 of 96 checks passed
@ji-eunsoo ji-eunsoo mentioned this pull request May 14, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 機能追加
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants