Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump symfony/security from 3.4.42 to 3.4.48 #5042

Merged
merged 1 commit into from
May 27, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 13, 2021

Bumps symfony/security from 3.4.42 to 3.4.48.

Release notes

Sourced from symfony/security's releases.

v3.4.48

Changelog (symfony/security@v3.4.47...v3.4.48)

  • no significant changes

v3.4.47

Changelog (symfony/security@v3.4.46...v3.4.47)

  • no changes

v3.4.46

Changelog (symfony/security@v3.4.45...v3.4.46)

  • no changes

v3.4.45

Changelog (symfony/security@v3.4.44...v3.4.45)

  • no changes

v3.4.44

Changelog (symfony/security@v3.4.43...v3.4.44)

  • no changes

v3.4.43

Changelog (symfony/security@v3.4.42...v3.4.43)

  • no changes
Commits
  • 06dbfe4 [Security][Guard] Prevent user enumeration via response content
  • 7f92437 minor #38848 Missing translations for Chinese (zh_TW) #38733 (fd6130)
  • d283d9d Missing translations for Chinese (zh_TW) #38733
  • 46f91cf Missing translations for Chinese (zh_CN) #38732
  • fb09526 minor #38830 [Security] Add missing translations for Ukrainian (uk) (Comrade42)
  • 8172d7a minor #38835 [Translation] added missing Albanian translations (abame)
  • 461d1ae [Translation] added missing Albanian translations
  • f645825 minor #38834 [Form, Security, Validator] Add missing Turkish translations (tr...
  • fe0bb0a [Form, Security, Validator] Add missing Turkish translations (tr)
  • 4d89842 minor #38793 38737 add missing dutch translation (JohJohan)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels May 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #5042 (9a3e5db) into 4.0 (fc2915b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.0    #5042      +/-   ##
============================================
- Coverage     76.19%   76.15%   -0.04%     
  Complexity     6124     6124              
============================================
  Files           437      437              
  Lines         20744    20744              
============================================
- Hits          15805    15797       -8     
- Misses         4939     4947       +8     
Flag Coverage Δ Complexity Δ
tests 76.15% <ø> (-0.04%) 6124.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Eccube/Form/Type/Admin/MemberType.php 75.00% <0.00%> (-20.84%) 11.00% <0.00%> (ø%)
src/Eccube/Service/OrderPdfService.php 95.03% <0.00%> (+0.35%) 51.00% <0.00%> (ø%)
.../Eccube/Doctrine/Common/CsvDataFixtures/Loader.php 82.05% <0.00%> (+2.56%) 16.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2915b...9a3e5db. Read the comment docs.

Copy link
Contributor

@okazy okazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自動テストが通っているので問題なし。

@okazy
Copy link
Contributor

okazy commented May 26, 2021

symfony/securityv3.4.48 へアップデートしていますが、根治対応には v3.4.49 以降のようです。
https://symfony.com/blog/cve-2021-21424-prevent-user-enumeration-in-authentication-mechanisms

関連
#5041

一旦こちらは取り込めればともいます。

@okazy okazy merged commit 1357e68 into 4.0 May 27, 2021
@dependabot dependabot bot deleted the dependabot/composer/symfony/security-3.4.48 branch May 27, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code Status: ready-for-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants