PHPStan による静的解析の導入

.github/workflows/deploy.yml

@@ -51,6 +51,7 @@ jobs:
           rm -rf $GITHUB_WORKSPACE/.coveralls.yml
           rm -rf $GITHUB_WORKSPACE/.php_cs.dist
           rm -rf $GITHUB_WORKSPACE/phpunit.xml.dist
+          rm -rf $GITHUB_WORKSPACE/phpstan.neon.dist
           rm -rf $GITHUB_WORKSPACE/app.json
           rm -rf $GITHUB_WORKSPACE/Procfile
           rm -rf $GITHUB_WORKSPACE/LICENSE.txt

.github/workflows/phpstan.yml

@@ -0,0 +1,36 @@
+name: PHPStan
+on:
+  push:
+    branches:
+      - '*'
+    tags:
+      - '*'
+    paths:
+      - '**'
+      - '!*.md'
+  pull_request:
+    paths:
+      - '**'
+      - '!*.md'
+
+jobs:
+  phpstan:
+    name: PHPStan
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: "Checkout"
+      uses: actions/checkout@v2
+    - name: Setup PHP
+      uses: nanasess/setup-php@master
+      with:
+        php-version: '7.4'
+    - name: composer install
+      run: |
+        sudo composer selfupdate --1
+        composer install --dev --no-interaction -o --apcu-autoloader
+    - name: PHPStan
+      run: |
+        composer require phpstan/phpstan --dev
+        vendor/bin/phpstan analyze src/ --error-format=github

.gitignore

@@ -45,6 +45,7 @@ composer.phar
 *.php~
 .env
 .maintenance
+*.neon
 
 ###> symfony/phpunit-bridge ###
 .phpunit

phpstan.neon.dist

@@ -0,0 +1,6 @@
+parameters:
+  level: 0
+  ignoreErrors:
+    -
+      message: "#^Function twig_localized_date_filter not found\\.$#"
+      path: src/Eccube/Twig/Extension/IntlExtension.php

src/Eccube/EventListener/TransactionListener.php

@@ -13,7 +13,7 @@
 
 namespace Eccube\EventListener;
 
-use Doctrine\Dbal\Connection;
+use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\TransactionIsolationLevel;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\EntityManagerInterface;