購入手続き中でもPurchaseContextでユーザー情報を取得できるようにする #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okazy
approved these changes
Nov 13, 2020
| @@ -33,7 +33,7 @@ class PurchaseContext extends \SplObjectStorage | |||
|
|
|||
| const CART_FLOW = 'cart'; | |||
|
|
|||
| public function __construct(ItemHolderInterface $originHolder = null, Customer $user = null) | |||
| public function __construct(ItemHolderInterface $originHolder = null, ?Customer $user = null) | |||
There was a problem hiding this comment.
インタフェースの変更とはなりますが、制限を緩和するだけなので問題ないかと思います。
|
ありがとうございます！マージしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
購入手続き中でもPurchaseContextでユーザー情報を取得できるようにしてほしいです。
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目