Skip to content

Commit

Permalink
未完成なのにもかかわらず、Skip されているテストを Incomplete に修正
Browse files Browse the repository at this point in the history
  • Loading branch information
@nanasess
nanasess committed Jul 30, 2021
1 parent 06b3d7c commit 19737e3
Show file tree
Hide file tree
Showing 15 changed files with 26 additions and 25 deletions.
4 changes: 2 additions & 2 deletions codeception/acceptance/EA07BasicinfoCest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function basicinfo_支払方法入れ替え(AcceptanceTester $I)

public function basicinfo_支払方法登録(AcceptanceTester $I)
{
$I->getScenario()->skip('EA0705-UC01-T01 支払方法 登録');
$I->getScenario()->incomplete('EA0705-UC01-T01 支払方法 登録');
$I->wantTo('EA0705-UC01-T01 支払方法 登録');

// 表示
Expand All @@ -105,7 +105,7 @@ public function basicinfo_支払方法登録(AcceptanceTester $I)

public function basicinfo_支払方法編集(AcceptanceTester $I)
{
$I->getScenario()->skip('EA0705-UC01-T01 支払方法 登録');
$I->getScenario()->incomplete('EA0705-UC01-T01 支払方法 登録');
$I->wantTo('EA0705-UC02-T01 支払方法 編集');

// 表示
Expand Down
2 changes: 1 addition & 1 deletion codeception/acceptance/EA08SysteminfoCest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ public function systeminfo_セキュリティ管理SSL(AcceptanceTester $I)
{
$I->wantTo('EA0804-UC01-T04 セキュリティ管理 - SSL強制');

$I->getScenario()->skip('このテストを通すと以降のテストが通らなくなってしまっているので一時的にスキップ');
$I->getScenario()->incomplete('このテストを通すと以降のテストが通らなくなってしまっているので一時的にスキップ');

$httpBaseUrl = $I->getBaseUrl();
$I->amOnUrl($httpBaseUrl);
Expand Down
1 change: 1 addition & 0 deletions codeception/acceptance/EF02ProductCest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public function product_商品一覧初期表示(AcceptanceTester $I)

public function product_商品一覧ヘッダ以外のカテゴリリンク(AcceptanceTester $I)
{
$I->getScenario()->incomplete('テスト項目を要確認');
$I->wantTo('EF0201-UC01-T02 商品一覧ページ ヘッダ以外のカテゴリリンク');
$I->amOnPage('/');

Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Command/PluginDevelopEntityFromDbTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function testFirst()
{
// TODO question helperのunit testの実装方法を変更
// http://symfony.com/doc/current/components/console/helpers/questionhelper.html
$this->markTestSkipped();
$this->markTestIncomplete();

$code = 'PluginUnittestSample';

Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Command/PluginDevelopEntityFromYamlTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function testFirst()
{
// TODO question helperのunit testの実装方法を変更
// http://symfony.com/doc/current/components/console/helpers/questionhelper.html
$this->markTestSkipped();
$this->markTestIncomplete();

$code = 'PluginUnittestSample';

Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Command/PluginDevelopGenerateTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function testFirst()
{
// TODO question helperのunit testの実装方法を変更
// http://symfony.com/doc/current/components/console/helpers/questionhelper.html
$this->markTestSkipped();
$this->markTestIncomplete();

$code = 'PluginUnittestSample';

Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Form/Type/Admin/LogTypeTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function tearDown()
public function testValidData()
{
if (!file_exists($this->logTest)) {
$this->markTestSkipped('テスト時には'.$this->fileName.'は存在しないのでテストできない');
$this->markTestIncomplete('テスト時には'.$this->fileName.'は存在しないのでテストできない');
}
$this->form->submit($this->formData);
$this->assertTrue($this->form->isValid());
Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Form/Type/Install/Step4TypeTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public function setUp()
public function testInvalidData()
{
// Request に依存しているため WebTest で代替する
$this->markTestSkipped('Can not support of FormInterface::submit()');
$this->markTestIncomplete('Can not support of FormInterface::submit()');

$this->form->submit($this->formData);
$this->assertFalse($this->form->isValid());
Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Service/EntityProxyServiceTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function testGenerate()

public function testGenerateFromOriginalFile()
{
$this->markTestSkipped();
$this->markTestIncomplete();

$findSequence = static function (Tokens $tokens) {
return $tokens->findSequence([
Expand Down
6 changes: 3 additions & 3 deletions tests/Eccube/Tests/Service/MailServiceTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ public function testSendPasswordResetCompleteMail()
public function testConvertMessageISO()
{
// TODO https://github.com/EC-CUBE/ec-cube/issues/2402#issuecomment-362487022
$this->markTestSkipped('実装確認中のためスキップ');
$this->markTestIncomplete('実装確認中のためスキップ');
$config = $this->app['config'];
$config['mail']['charset_iso_2022_jp'] = true;
$this->app['config'] = $config;
Expand Down Expand Up @@ -426,7 +426,7 @@ public function testConvertMessageISO()
public function testConvertMessageUTF()
{
// TODO https://github.com/EC-CUBE/ec-cube/issues/2402#issuecomment-362487022
$this->markTestSkipped('実装確認中のためスキップ');
$this->markTestIncomplete('実装確認中のためスキップ');

$config = $this->app['config'];
$config['mail']['charset_iso_2022_jp'] = false;
Expand Down Expand Up @@ -460,7 +460,7 @@ public function testConvertMessageUTF()
*/
public function testSendShippingNotifyMail()
{
$this->markTestSkipped('実装確認中のためスキップ');
$this->markTestIncomplete('実装確認中のためスキップ');
$Order = $this->Order;
/** @var Shipping $Shipping */
$Shipping = $Order->getShippings()->first();
Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Service/Payment/PaymentMethodTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class PaymentMethodTest extends EccubeTestCase
{
public function testConstructorInjection()
{
$this->markTestSkipped();
$this->markTestIncomplete();

$Customer = $this->createCustomer();
$Order = $this->createOrder($Customer);
Expand Down
4 changes: 2 additions & 2 deletions tests/Eccube/Tests/Web/Admin/Order/EditControllerTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public function testNotUpdateLastBuyDate()

public function testOrderCustomerInfo()
{
$this->markTestSkipped('顧客の購入回数と購入金額の実装が完了するまでスキップ');
$this->markTestIncomplete('顧客の購入回数と購入金額の実装が完了するまでスキップ');
$this->markTestIncomplete('EditController is not implemented.');
$Customer = $this->createCustomer();
$Order = $this->createOrder($Customer);
Expand Down Expand Up @@ -304,7 +304,7 @@ public function testOrderProcessingToFrontConfirm()
$this->actual = $EditedOrder->getOrderStatus()->getId();
$this->verify();

$this->markTestSkipped('フロントとのセッション管理の実装が完了するまでスキップ');
$this->markTestIncomplete('フロントとのセッション管理の実装が完了するまでスキップ');
// フロント側から, product_class_id = 1 をカート投入
$client = $this->createClient();
$client->request(
Expand Down
16 changes: 8 additions & 8 deletions tests/Eccube/Tests/Web/Admin/Order/EditControllerWithMultipleTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ public function setUp()

public function testRoutingAdminOrderNew()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$this->client->request('GET', $this->app->url('admin_order_new'));
$this->assertTrue($this->client->getResponse()->isSuccessful());
}

public function testRoutingAdminOrderNewPost()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$Shippings = [];
$Shippings[] = $this->createShipping($this->Product->getProductClasses()->toArray());
Expand All @@ -68,7 +68,7 @@ public function testRoutingAdminOrderNewPost()

public function testRoutingAdminOrderEdit()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$Customer = $this->createCustomer();
$Order = $this->createOrder($Customer);
Expand All @@ -79,7 +79,7 @@ public function testRoutingAdminOrderEdit()

public function testRoutingAdminOrderEditPost()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$Shippings = [];
$Shippings[] = $this->createShipping($this->Product->getProductClasses()->toArray());
Expand Down Expand Up @@ -189,7 +189,7 @@ public function testSearchProduct()
*/
public function testOrderProcessingToFrontConfirm()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$Customer = $this->createCustomer();
$Order = $this->createOrder($Customer);
Expand Down Expand Up @@ -283,7 +283,7 @@ public function testOrderProcessingToFrontConfirm()
*/
public function testOrderProcessingWithTax()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$Shippings = [];
$Shippings[] = $this->createShipping($this->Product->getProductClasses()->toArray());
Expand Down Expand Up @@ -338,7 +338,7 @@ public function testOrderProcessingWithTax()

public function testOrderEditWithShippingItemDelete()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$Shippings = [];
$Shippings[] = $this->createShipping($this->Product->getProductClasses()->toArray());
Expand Down Expand Up @@ -398,7 +398,7 @@ public function testOrderEditWithShippingItemDelete()

public function testOrderEditWithShippingDelete()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$Shippings = [];
$Shippings[] = $this->createShipping($this->Product->getProductClasses()->toArray());
Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Web/Admin/Order/OrderControllerTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ public function testSearchWithEmail()
*/
public function testBulkOrderStatus($orderStatusId)
{
$this->markTestSkipped('使用していないルーティングのためスキップ.');
$this->markTestIncomplete('使用していないルーティングのためスキップ.');
// case true
$orderIds = [];
/** @var Order[] $Orders */
Expand Down
2 changes: 1 addition & 1 deletion tests/Eccube/Tests/Web/ShoppingControllerTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ public function testShippingChangeWithPost()
*/
public function testShippingShippingPost()
{
$this->markTestSkipped('新しい配送管理の実装が完了するまでスキップ');
$this->markTestIncomplete('新しい配送管理の実装が完了するまでスキップ');

$faker = $this->getFaker();
$Customer = $this->logIn();
Expand Down

0 comments on commit 19737e3

Please sign in to comment.