Add option to specify tars to check or extract #170
Conversation
forsyth2
added
enhancement
semver: new feature
forsyth2
force-pushed
the
specify-starting-tar
branch
7 times, most recently
from
c8164ba to
baffaaa
Compare
zstash/extract.py
Outdated
| else: # TODO: should this always be run (i.e., not if/else?) | ||
| # Find matching files | ||
| for args_file in args.files: | ||
| cur.execute( | ||
| u"select * from files where name GLOB ? or tar GLOB ?", | ||
| (args_file, args_file), | ||
| ) | ||
| matches_ = matches_ + cur.fetchall() |
There was a problem hiding this comment.
Should we still run this section if --tars is being used? That is, is there a use case where a user would specify zstash check --hpss=<HPSS> --tars=<tars> <specific files>? It seems like if a user is requesting specific files, it wouldn't be necessary to specify which tars to look at.
There was a problem hiding this comment.
That's right. When specifying the tar files, we don't need the --tars option - It's redundant.
There was a problem hiding this comment.
@tangq If a user specifies both <tars> and <specific files>, what should be the expected behavior?
- Just check/extract
<tars> - Just check/extract
<specific files> - Print error message saying to only specify one
There was a problem hiding this comment.
I would agree. @golaz which is your preference?
There was a problem hiding this comment.
@forsyth2 and @tangq : this is an edge case and I would think that it is unlikely a user would want to specify <tars> and <specific files> simultaneously. Therefore, if it's relatively straightforward to implement, I would suggest option 3 as well to make sure there is no room for misunderstanding from an unsuspecting user.
zstash/extract.py
Outdated
| else: # TODO: should this always be run (i.e., not if/else?) | ||
| # Find matching files | ||
| for args_file in args.files: | ||
| cur.execute( | ||
| u"select * from files where name GLOB ? or tar GLOB ?", | ||
| (args_file, args_file), | ||
| ) | ||
| matches_ = matches_ + cur.fetchall() |
There was a problem hiding this comment.
That's right. When specifying the tar files, we don't need the --tars option - It's redundant.
forsyth2
force-pushed
the
specify-starting-tar
branch
3 times, most recently
from
de9857b to
e139de7
Compare
|
Thanks @forsyth2. The changes look good to me. |
forsyth2
force-pushed
the
specify-starting-tar
branch
from
e139de7 to
1f8dbe3
Compare
forsyth2
changed the title
Specify starting tar. Resolves #164.