Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diags defaults #458

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Update diags defaults #458

merged 1 commit into from
Jul 17, 2023

Conversation

forsyth2
Copy link
Collaborator

Update diags defaults. Addresses the first item of #454 ("update existing campaigns by adding new defaults e3sm_diags sets")

@forsyth2 forsyth2 added the semver: small improvement Small improvement (will increment patch version) label Jul 17, 2023
@forsyth2 forsyth2 self-assigned this Jul 17, 2023
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jul 17, 2023

Defaults after this pull request merges:

sets default.ini cryosphere high_res_v1 water_cycle
aerosol_aeronet ✔️ ✔️ ✔️
aerosol_budget ✔️ ✔️ ✔️
annual_cycle_zonal_mean ✔️ ✔️ ✔️
area_mean_time_series
cosp_histogram ✔️ ✔️ ✔️
diurnal_cycle ✔️ ✔️
enso_diags ✔️ ✔️
lat_lon ✔️ ✔️ ✔️
meridional_mean_2d ✔️ ✔️ ✔️
polar ✔️ ✔️ ✔️
qbo ✔️ ✔️
streamflow ✔️ ✔️
tc_analysis
zonal_mean_2d ✔️ ✔️ ✔️
zonal_mean_2d_stratosphere ✔️ ✔️ ✔️
zonal_mean_xy ✔️ ✔️ ✔️

@forsyth2 forsyth2 merged commit a036e61 into main Jul 17, 2023
@forsyth2 forsyth2 deleted the update-diags-defaults branch July 17, 2023 23:29
@mahf708
Copy link

mahf708 commented Oct 11, 2023

@chengzhuzhang this is the one, xref E3SM-Project/e3sm_diags#738

@chengzhuzhang
Copy link
Collaborator

Thanks @mahf708 ! It would be nice to revert the changes, to bring the familiar order back..

@forsyth2
Copy link
Collaborator Author

Did we just want to put lat_lon first or revert the entire commit? E3SM Diags has a lot of sets now and I think it really improves readability/usability to have them listed (at least mostly) alphabetical. For instance, it makes it much easier to quickly see if you're including all the sets you wanted to.

@chengzhuzhang
Copy link
Collaborator

My preference would be to revert to previous order. The idea is that core sets are listed before specialized sets. And we want to make the list relatively permanent, and appending new sets when they become available. @forsyth2 could you fix this? Maybe we can patch the conda-forge release for this change.

@forsyth2 forsyth2 mentioned this pull request Oct 11, 2023
@forsyth2
Copy link
Collaborator Author

could you fix this?

#521

Maybe we can patch the conda-forge release for this change.

You mean include it in the upcoming E3SM Unified patch release? (Along with E3SM-Project/zstash#304)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: small improvement Small improvement (will increment patch version)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants