Refactor coupled_global.py
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forsyth2
added
the
semver: small improvement
forsyth2
commented
Dec 20, 2022
forsyth2
force-pushed
the
refactor-coupled-global
branch
from
3086247 to
b9500c7
Compare
forsyth2
force-pushed
the
refactor-coupled-global
branch
from
b9500c7 to
5885674
Compare
This was referenced Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
coupled_global.pyby using a common function for all plots. This will make it easier to add new plots.param_dictfor each plot with its unique function in the current https://github.com/E3SM-Project/zppy/blob/main/zppy/templates/coupled_global.pyglobal_time_series. In theory, no images will need to be updated (the generated bash files will change, however).