Update package versions #321

forsyth2 · 2022-10-05T22:09:16Z

Change jinja2 version. Resolves #318. Note that this does not break #252, since the version is still above 3.0.0. Also updates various other package versions.

forsyth2 · 2022-10-07T01:55:28Z

@tomvothecoder When you have time, can you review this please? I was finally able to get all the checks to pass on CI/CD. I ended up using the latest available version of everything -- except I ended up using Python 3.8 rather than 3.10 to avoid dependency conflicts.

I'm not sure I updated everything correctly outside conda/dev.yml though -- i.e., .pre-commit-config.yaml, .github/workflows/build_workflow.yml, .github/workflows/release_workflow.yml.

tomvothecoder · 2022-10-10T15:57:44Z

Sounds good, will review when I can fit this in (probably Thurs/Friday).

forsyth2 · 2022-10-12T18:19:57Z

Note: we want to look at supporting Python 3.9 rather than 3.8 as this PR currently does.

- Add line break between GH Actions job steps - Update Python versions to 3.9

tomvothecoder

Hey @forsyth2, please review my updates. The docs build locally and the GH Actions build is passing.

If you agree, please merge.

tomvothecoder · 2022-10-12T21:41:07Z

.github/workflows/build_workflow.yml

+      - name: Set up Python
        uses: actions/setup-python@v2
        with:
-          python-version: 3.7
+          python-version: 3.9


Updated to Python 3.9 (it will pick up the latest patch version, which is 3.9.13).

tomvothecoder · 2022-10-12T21:41:12Z

.github/workflows/build_workflow.yml

      - name: Set up Python
        uses: actions/setup-python@v2
        with:
-          python-version: 3.7
+          python-version: 3.9


Updated to Python 3.9 (it will pick up the latest patch version, which is 3.9.13).

tomvothecoder · 2022-10-12T21:41:35Z

.github/workflows/build_workflow.yml

      # Using pip for Sphinx dependencies because it takes too long to reproduce a conda environment (~10 secs vs. 3-4 mins)
      - name: Install Dependencies
        run: |
          python -m pip install --upgrade pip
-          pip install sphinx==4.0.2 sphinx_rtd_theme==0.5.2 sphinx-multiversion==0.2.4 docutils==0.16
+          pip install sphinx==5.2.3 sphinx_rtd_theme==1.0.0 sphinx-multiversion==0.2.4 docutils==0.16


Updated these doc dependencies in the GH Actions to align with dev.yml

tomvothecoder · 2022-10-12T21:41:57Z

.github/workflows/build_workflow.yml

      - name: Build Sphinx Docs
        run: |
          cd docs
          sphinx-multiversion source _build/html
+


Added line breaks between steps to make them easier to read.

tomvothecoder · 2022-10-12T21:42:05Z

.github/workflows/release_workflow.yml

        with:
          activate-environment: "zppy_publish"
          channel-priority: strict
-          python-version: 3.7
+          python-version: 3.9


Updated to Python 3.9 (it will pick up the latest patch version, which is 3.9.13).

tomvothecoder · 2022-10-12T21:42:10Z

.github/workflows/release_workflow.yml

      - name: Set up Python
        uses: actions/setup-python@v2
        with:
-          python-version: 3.7
+          python-version: 3.9


Updated to Python 3.9 (it will pick up the latest patch version, which is 3.9.13).

tomvothecoder · 2022-10-12T21:42:29Z

.github/workflows/release_workflow.yml

      # Using pip for Sphinx dependencies because it takes too long to reproduce a conda environment (~10 secs vs. 3-4 mins)
      - name: Install Dependencies
        run: |
          python -m pip install --upgrade pip
-          pip install sphinx==4.0.2 sphinx_rtd_theme==0.5.2 sphinx-multiversion==0.2.4 docutils==0.16
+          pip install sphinx==5.2.3 sphinx_rtd_theme==1.0.0 sphinx-multiversion==0.2.4 docutils==0.16


Updated these doc dependencies in the GH Actions to align with dev.yml

tomvothecoder · 2022-10-12T21:42:40Z

.github/workflows/release_workflow.yml

@@ -82,29 +82,36 @@ jobs:
          restore-keys: |
            ${{ runner.os }}-pip-
            ${{ runner.os }}-
+


Added line breaks between steps to make them easier to read.

tomvothecoder · 2022-10-12T21:43:39Z

conda/dev.yml

+  - python=3.9.13
+  - pip=22.2.2


I moved python and pip to the top because that's where they are usually listed since they are "system" level dependencies required to install the other packages.

tomvothecoder · 2022-10-12T21:44:02Z

conda/dev.yml

+  - flake8-isort=4.2.0  # version from https://anaconda.org/conda-forge/flake8-isort
+  - mypy=0.982          # version from https://anaconda.org/conda-forge/mypy
+  - pre-commit=2.20.0   # version from https://anaconda.org/conda-forge/pre-commit
+  - tbump=6.9.0


tbump is now available on conda-forge so it doesn't need to be installed through - pip :

forsyth2 · 2022-10-12T23:30:34Z

Thanks @tomvothecoder!

Change jinja2 version

5cdcad7

forsyth2 added DevOps CI/CD, configuration, etc. semver: bug Bug fix (will increment patch version) Documentation Files in `docs` modified labels Oct 5, 2022

forsyth2 added this to the December 2022 Requirements milestone Oct 5, 2022

forsyth2 self-assigned this Oct 5, 2022

forsyth2 mentioned this pull request Oct 5, 2022

Fix ImportError: cannot import name 'environmentfilter' from 'jinja2' #318

Closed

forsyth2 removed this from the December 2022 Requirements milestone Oct 6, 2022

Fix pre-commit error

60445c0

forsyth2 force-pushed the fix-jinja-error branch from 33d15b7 to 60445c0 Compare October 7, 2022 01:49

forsyth2 marked this pull request as ready for review October 7, 2022 01:55

forsyth2 requested a review from tomvothecoder October 7, 2022 01:55

Update dev env and GH Actions workflows

9f8b473

- Add line break between GH Actions job steps - Update Python versions to 3.9

tomvothecoder approved these changes Oct 12, 2022

View reviewed changes

forsyth2 changed the title ~~Change jinja2 version~~ Update package versions Oct 12, 2022

forsyth2 merged commit 8e6b049 into main Oct 12, 2022

forsyth2 deleted the fix-jinja-error branch October 12, 2022 23:30

This was referenced Oct 28, 2022

Perlmutter support E3SM-Project/zstash#227

Merged

Update package versions E3SM-Project/zstash#228

Merged

forsyth2 removed the Documentation Files in `docs` modified label Nov 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update package versions #321

Update package versions #321

forsyth2 commented Oct 5, 2022 •

edited

Loading

forsyth2 commented Oct 7, 2022

tomvothecoder commented Oct 10, 2022 •

edited

Loading

forsyth2 commented Oct 12, 2022

tomvothecoder left a comment

tomvothecoder Oct 12, 2022

tomvothecoder Oct 12, 2022

tomvothecoder Oct 12, 2022

tomvothecoder Oct 12, 2022

tomvothecoder Oct 12, 2022

tomvothecoder Oct 12, 2022

tomvothecoder Oct 12, 2022

tomvothecoder Oct 12, 2022

tomvothecoder Oct 12, 2022 •

edited

Loading

tomvothecoder Oct 12, 2022

forsyth2 commented Oct 12, 2022

Update package versions #321

Update package versions #321

Conversation

forsyth2 commented Oct 5, 2022 • edited Loading

forsyth2 commented Oct 7, 2022

tomvothecoder commented Oct 10, 2022 • edited Loading

forsyth2 commented Oct 12, 2022

tomvothecoder left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomvothecoder Oct 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

forsyth2 commented Oct 12, 2022

forsyth2 commented Oct 5, 2022 •

edited

Loading

tomvothecoder commented Oct 10, 2022 •

edited

Loading

tomvothecoder Oct 12, 2022 •

edited

Loading