-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILAMB task revision #230
ILAMB task revision #230
Conversation
76d7a25
to
cfce17f
Compare
cfce17f
to
592ebcc
Compare
It took some debugging to create the single initial commit for this pull request. I've listed what I believe to be the necessary steps below:
|
c8f863c
to
83d5f5c
Compare
83d5f5c
to
3210894
Compare
@chengzhuzhang This pull request contains two commits. The first is all the work you did on #197. The second is my revisions: 3210894 -- that's what needs a review. Once we merge this, I'll update the expected files for the integration tests. Notable changes:
|
Also note I'll handle #229 in a follow-up pull request. |
@@ -33,6 +33,12 @@ years = "1850:1854:2", | |||
input_files = "eam.h0" | |||
input_subdir = "archive/atm/hist" | |||
|
|||
[[ atm_monthly_180x360_aave_ilamb ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be [[ atm_monthly_180x360_aave ]]? I think the logic is if ts_fmt=cmip, both nco convention time series and cmip time series are generated.
And this sub session can be both a dependency of both e3sm_diags and ilamb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it must have been some issue in debugging that made me think it required a separate subtask. It looks like it works fine using the same subtask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ryan, the PR looks good, I only has one query left as a single line comment. Thanks!
Expected files for integration tests (https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/zppy_test_complete_run_www/) have been updated. |
Add ILAMB task. Revision of #197. Resolves #133. Resolves #134. A future pull request will handle #229.