-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cori base_url #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this in MPAS-Analysis and the resulting URL was:
https://portal.nersc.gov/cfs/e3sm//xylar/analysis_testing/cori-haswell/mache_update_cori_base_url/main_py3.9
This works fine (try it) but it doesn't look nice so let's remove the unneeded trailing /
.
mache/machines/cori-haswell.cfg
Outdated
@@ -34,7 +34,7 @@ group = e3sm | |||
base_path = /global/cfs/cdirs/e3sm/www | |||
|
|||
# The base URL that corresponds to the base path | |||
base_url = https://portal.nersc.gov/project/e3sm/ | |||
base_url = https://portal.nersc.gov/cfs/e3sm/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base_url = https://portal.nersc.gov/cfs/e3sm/ | |
base_url = https://portal.nersc.gov/cfs/e3sm |
mache/machines/cori-knl.cfg
Outdated
@@ -28,7 +28,7 @@ group = e3sm | |||
base_path = /global/cfs/cdirs/e3sm/www | |||
|
|||
# The base URL that corresponds to the base path | |||
base_url = https://portal.nersc.gov/project/e3sm/ | |||
base_url = https://portal.nersc.gov/cfs/e3sm/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base_url = https://portal.nersc.gov/cfs/e3sm/ | |
base_url = https://portal.nersc.gov/cfs/e3sm |
Results from my test can be found at:
|
@forsyth2, could you remove the trailing |
@xylar Thanks for testing!
Sure, should I do that for the other settings too? I was running into the https://github.com/E3SM-Project/mache/blob/main/mache/machines/cori-haswell.cfg:
but https://github.com/E3SM-Project/mache/blob/main/mache/machines/compy.cfg:
|
@forsyth2, yes, please remove trailing |
I probably won't re-test MPAS-Analysis after those changes because it's a lot of trouble to test on each machine. We'll just hope for the best... |
0f91bfe
to
cd06db2
Compare
@xylar I just pushed an amended commit. If that looks good to you, then it's ready to merge. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @forsyth2!
@forsyth2 and @chengzhuzhang, are you keen to have this functionality soon? I could do a 1.6.0 release if need be but would otherwise wait for other changes that might come soon (e.g. #48). |
Hey @xylar thanks for checking. We can wait, no need to have a separate release for this functionality... |
Update Cori
base_url
to use/cfs/
rather than/project/
. Resolves #52.