Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit OMP* environment variables with gnu on chrysalis #184

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Omit OMP* environment variables with gnu on chrysalis #184

merged 1 commit into from
Jul 23, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 23, 2024 •
edited
Loading

They are causing very bad slowdown in the Polaris pr test suite.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar
Omit OMP* environment variables with gnu on chrysalis
ee072e6 
They are causing very bad slowdown in the Polaris pr test suite.
@xylar xylar added bug Something isn't working spack Changes relate to creating conda and Spack environments, and creating a load script labels Jul 23, 2024
@xylar xylar requested a review from altheaden July 23, 2024 15:22
@xylar
Copy link
Collaborator Author

xylar commented Jul 23, 2024 •
edited
Loading

Testing

I ran 2 versions of the Polaris pr test suite on Chrysalis with gnu, one with these environment variables in the load script and one with them removed. The former ran so slowly that it timed out in a 1-hour job script while the former completed in just over 2 minutes.

@xylar
Copy link
Collaborator Author

xylar commented Jul 23, 2024

@altheaden, just a quick review by inspection would be sufficient here. I'm also going to patch the mache release to include this fix.

@xylar xylar mentioned this pull request Jul 23, 2024
Merged
34 tasks
altheaden
altheaden reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@altheaden altheaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging.

@altheaden altheaden merged commit 91065b4 into E3SM-Project:main Jul 23, 2024
6 checks passed
@altheaden altheaden deleted the comment-out-omp-in-chrys-gnu branch July 23, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altheaden altheaden altheaden left review comments

Assignees

@altheaden altheaden

Labels
bug Something isn't working spack Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @altheaden