Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a variable name displayed in viewer #820

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

chengzhuzhang
Copy link
Contributor

@chengzhuzhang chengzhuzhang commented Jun 20, 2024

Description

Checklist

  • [x ] My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [x ] My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@chengzhuzhang
Copy link
Contributor Author

@kchong75 this change should fix the incorrect name displayed. Please have a review and let me know if there is any questions.

@tomvothecoder this fix again needs to be brought into cdat migration branch. Maybe we should create a label for this type of fix, so that we can group them when updating cdat-migration-fy24?

@kchong75
Copy link

@kchong75 this change should fix the incorrect name displayed. Please have a review and let me know if there is any questions.

Thank you for fixing it! The name looks correct now.

@tomvothecoder
Copy link
Collaborator

@tomvothecoder this fix again needs to be brought into cdat migration branch. Maybe we should create a label for this type of fix, so that we can group them when updating cdat-migration-fy24?

I added the GH issue (#818) to the project board and labeled it with cdat-migration-fy24.

One caveat is that closing the GH issue will move it to "Done" on the project board unless we open a duplicate issue specifically for the dev branch.

@chengzhuzhang chengzhuzhang merged commit dbd65ec into main Jul 1, 2024
4 checks passed
@chengzhuzhang chengzhuzhang deleted the fix_issue_818 branch July 1, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants