Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: speed up valgrind testing to make it doable #6769

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Nov 22, 2024

Our valgrind testsuite for eamxx standalone testing was too slow, to the point that it never completed before timing out. This PR compromises between exec speed and analysis thoroughness by:

  • using CMAKE_BUILD_TYPE=RelWithDebInfo: less optimized than Release (-O2 vs -O3), and adds debug symbols in case we want to manually run through a debugger
  • limiting the number of OMP threads to 2: if we are doing bad index math to cause OOB access or uninitialized var usage, we can spot that with just 2 threads. Valgrind does not do concurrency checks anyways.

Depends-On: #6761

@bartgol bartgol added Testing Anything related to unit/system tests EAMxx PRs focused on capabilities for EAMxx labels Nov 22, 2024
@bartgol bartgol requested a review from jgfouca November 22, 2024 17:20
@bartgol bartgol self-assigned this Nov 22, 2024
@bartgol bartgol marked this pull request as draft November 22, 2024 17:20
Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6769/
on branch gh-pages at 2024-11-22 17:23 UTC

* Use RelWithDebInfo to compromise speed and analysis
* Limit number of OMP threads to 2
@bartgol bartgol force-pushed the bartgol/eamxx/valgrind-testing-mods branch from 8de2613 to fb91a5e Compare November 22, 2024 18:20
@bartgol bartgol marked this pull request as ready for review November 22, 2024 18:20
@bartgol bartgol merged commit 49fdbe3 into master Nov 23, 2024
17 of 21 checks passed
@bartgol bartgol deleted the bartgol/eamxx/valgrind-testing-mods branch November 23, 2024 00:03
@bartgol bartgol restored the bartgol/eamxx/valgrind-testing-mods branch November 23, 2024 00:03
@bartgol bartgol deleted the bartgol/eamxx/valgrind-testing-mods branch November 23, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAMxx PRs focused on capabilities for EAMxx Testing Anything related to unit/system tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants