-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glc coupler budgets for active Greenland ice sheet [DRAFT] #6634
Draft
stephenprice
wants to merge
8
commits into
E3SM-Project:master
Choose a base branch
from
stephenprice:stephenprice/glc/update-glc-budgets-new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update glc coupler budgets for active Greenland ice sheet [DRAFT] #6634
stephenprice
wants to merge
8
commits into
E3SM-Project:master
from
stephenprice:stephenprice/glc/update-glc-budgets-new
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update various bits of code needed for completing and testing of glc coupler budgets. Still very much in the testing and debugging phase.
Code additions and debugging for addition of Greenland surface mass balance terms to glc budget code, including temporary lines for debugging and validation.
… component Given known number of time steps smb flux is accumulated over, x2g_ smb flux term in budget table now agrees with value calculated from mali and cpl hist files (still need to add support for automatically determining number of averaging steps). Similar support on l2x_ side is close (summing product of accumulation fluxes in different MECs w/ area fractions and cell areas) but off in budget tables from cpl calculated values by ~5%.
Checkpointing changes to coupler budget code that accounts for l2x_ and g2x_ Greenland surface mass balance fluxes, with various lines supporting debugging outputs included. Cleaned up code without debug lines to follow.
Clean up commenting and debugging lines, leaving bare minimum needed to make draft PR understandable.
Notes: Jon has been meeting with Steve about this. Will test more for impact when no glc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This DRAFT PR adds functionality to coupler budget code so that x2g_ and l2x_ fields associated with Greenland ice sheet surface mass balance are accounted for in the coupler budget tables. Also added, but currently passing fields of zeroes, is support for g2x_ fields associated with iceberg fluxes when running with a dynamic Greenland ice sheet. Additional information for testing this PR is included in the notes below.