Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for RCEMIP phase 2 #6616

Merged
merged 12 commits into from
Sep 20, 2024
Merged

Updates for RCEMIP phase 2 #6616

merged 12 commits into from
Sep 20, 2024

Conversation

whannah1
Copy link
Contributor

@whannah1 whannah1 commented Sep 13, 2024

This adds compsets and new output variables to facilitate the E3SM and E3SM-MMF
contributions to phase 1 & 2 of the radiative-convective equilibrium model inter-comparison project (RCEMIP).

NOTE: in the original RCE compsets there was a slight error in the value of constant_zenith_deg being off by 1/100. This difference is inconsequential, but I wanted to fix it here to ensure consistency with the other RCEMIP models.

[non-BFB] - only for RCE cases because of updated constant_zenith_deg value

Copy link

github-actions bot commented Sep 13, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6616/
on branch gh-pages at 2024-09-20 00:44 UTC

Copy link
Contributor

@bogensch bogensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think if I did it I would have only one MW compset with the SST mean and delta being namelist parameters that could be defined at will by the user (similar to how I did it for the branch I have on SCREAM repo). But I also understand why you did it the way you did so that's just a comment.

rljacob added a commit that referenced this pull request Sep 18, 2024
This adds compsets and new output variables to facilitate the E3SM and E3SM-MMF
contributions to phase 1 & 2 of the radiative-convective equilibrium model inter-comparison project (RCEMIP).

[BFB]
@rljacob
Copy link
Member

rljacob commented Sep 19, 2024

@whannah1 did you expect some namelist diffs which lead to diffs with baselines?
BASE: constant_zenith_deg = 42.05
COMP: constant_zenith_deg = 42.04

Only in ERP_Ln9.ne4pg2_ne4pg2.FRCE and ERS_Ln9.ne4pg2_ne4pg2.FRCE-MMF1

@whannah1
Copy link
Contributor Author

@whannah1 did you expect some namelist diffs which lead to diffs with baselines? BASE: constant_zenith_deg = 42.05 COMP: constant_zenith_deg = 42.04

Only in ERP_Ln9.ne4pg2_ne4pg2.FRCE and ERS_Ln9.ne4pg2_ne4pg2.FRCE-MMF1

Yes, sorry I forgot to make a note about this. When I originally created the RCE compsets I made a tiny mistake in the value of constant_zenith_deg, which is inconsequential, but I wanted to correct it here anyway. I'll edit the description to clarify that the diff is expected.

@whannah1 whannah1 added the non-BFB PR makes roundoff changes to answers. label Sep 19, 2024
@rljacob
Copy link
Member

rljacob commented Sep 19, 2024

Also seeing a runtime error with this test: ERP_Ld3.ne4pg2_ne4pg2.FIDEAL.chrysalis_intel.allactive-pioroot1 on both chrysalis and pm-cpu.

@whannah1
Copy link
Contributor Author

@rljacob I confirmed that the latest commit fixes the FIDEAL test fail. I only did a single test on Chrysalis, but the fix should also fix the PM failure.

rljacob added a commit that referenced this pull request Sep 20, 2024
This adds compsets and new output variables to facilitate the E3SM and E3SM-MMF
contributions to phase 1 & 2 of the radiative-convective equilibrium model inter-comparison project (RCEMIP)

2nd merge of this PR
@rljacob rljacob merged commit cdb4ce6 into master Sep 20, 2024
8 of 9 checks passed
@rljacob rljacob deleted the whannah/atm/rcemip-phase-2-update branch September 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere compset data-models non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants