Interpinic expand netCDF filetypes allowed, forgive missing "month" dimension, update BOZ syntax #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and continue (instead of failing) when input has month dimension and output does not.
… modern compilers (per Xylar)
rljacob
reviewed
Sep 13, 2024
bishtgautam
approved these changes
Sep 18, 2024
|
Just so everyone knows, I'm building this tool on conda-forge via the |
|
@rljacob and @bishtgautam, I would like to have this in before the 3.0.1 tag. I can only build new conda packages for E3SM release tags (conda-forge policy) and I would like to have these updates for the next E3SM-Unified release in December. |
rljacob
approved these changes
Sep 22, 2024
bishtgautam
added a commit
that referenced
this pull request
Sep 23, 2024
… (PR #6614) This new feature allows `interpinic` to interpolate an ELM initial conditions file that require storage in `NC_FORMAT_64BIT_DATA` and other netCDF4 formats. [BFB] [Bugfix]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature allows
interpinicto interpolate an ELM initial conditions filethat require storage in
NC_FORMAT_64BIT_DATAand other netCDF4 formats.[BFB] [Bugfix]
[BFB] [Land] [Bugfix]
This is a revised re-submit of #6613 with addition of BOZ patch supplied by Xylar to comply with newer Fortran syntax.
The main modifications to
bishtgautam/lnd/interpinic-gnuimproveinterpinicto work with output datasets of any format. Previously,initerpinicfailed if output format was notNC_FORMAT_64BIT_OFFSET. Our new deep (16-layer) snowpack modifications require restart fields that exceed 4 GB in size for hi-res (e.g., r0125) ELM grids. This new feature successfully interpolates to new initial conditions that require storage in 'NC_FORMAT_64BIT_DATA' and netCDF4 formats. These modifications also remove the (sometimes) unnecessary constraint that if the input dataset contains the month dimension, then so must the output dataset. In practice the month dimension may be present in the input dataset though unused by any variable (i.e., month is a superfluous dimension). Thus requiring its presence in the output dataset can create an extra hurdle. Instead of dying,interpinicnow prints a warning about the situation and proceeds anyway.