Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable land ice frazil unless ISMF is on #6501

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cbegeman
Copy link
Contributor

@cbegeman cbegeman commented Jul 5, 2024

This PR turns land ice frazil off by default and re-enables it when ice-shelf melt fluxes are enabled in standalone or coupled mode. Land ice frazil is not enabled in data ISMF because frazil fluxes are already included in satellite-derived ISMF products.

[non-BFB] when ice-shelf cavities are present in the mesh and (ocn_ismf is off or ocn_ismf is data)
[BFB] when ice-shelf cavities are absent from the mesh or ice-shelf cavities are present in the mesh and (ocn_ismf is coupled or ocn_ismf is internal)

@cbegeman
Copy link
Contributor Author

cbegeman commented Jul 5, 2024

Further discussion located at E3SM-Ocean-Discussion#101

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on code inspection and previous review in E3SM-Ocean-Discussion#101

@xylar
Copy link
Contributor

xylar commented Jul 7, 2024

This will affect current production runs so will need to wait for maint-3.0 to be created.

Copy link
Member

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on review in Ocean Discussions PR.

@xylar xylar added the non-BFB PR makes roundoff changes to answers. label Jul 9, 2024
@rljacob rljacob added this to the v3.1beta milestone Jul 25, 2024
@jonbob
Copy link
Contributor

jonbob commented Oct 29, 2024

@cbegeman -- would you expect this PR to cause non-BFB behavior for a typical IcoswISC30E3r5 fully-coupled case?

@xylar
Copy link
Contributor

xylar commented Oct 29, 2024

@jonbob, that would be expected because there was frazil forming in the otherwise inactive cavities in WCYCL cases. That is the main reason we wanted to turn it off here -- we don't want that behavior when cavities are inactive.

@jonbob
Copy link
Contributor

jonbob commented Oct 29, 2024

Thanks @xylar. Do we have a long-ish comparison run to document the changed behavior then? I didn't see anything on the discussions page

@darincomeau
Copy link
Member

When this first came up several months ago, we quantified the impact of the unintentional land-ice frazil term in a WCYCL1850 case and confirmed it was very small. But we did not actually do a run with the desired behavior added here, where land-ice frazil is off when ice-shelf cavities are otherwise thermodynamically inactive (e.g. WCYCL cases).

I've started that run now on Anvil, will update.

@rljacob
Copy link
Member

rljacob commented Nov 4, 2024

@darincomeau any update?

@darincomeau
Copy link
Member

@darincomeau any update?

The run is in year 20 now, I think we were going to assess climate impact (relative to v3 piControl) at year 20 or 30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpas-ocean non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants